You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "James Perry (JIRA)" <ji...@apache.org> on 2008/12/17 16:53:44 UTC

[jira] Created: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

MarkupContainer's add(final Component child) does not initially check for a child null reference 
-------------------------------------------------------------------------------------------------

                 Key: WICKET-1984
                 URL: https://issues.apache.org/jira/browse/WICKET-1984
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.5
            Reporter: James Perry
             Fix For: 1.3.6


More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

Posted by "James Perry (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Perry updated WICKET-1984:
--------------------------------

    Priority: Minor  (was: Major)

> MarkupContainer's add(final Component child) does not initially check for a child null reference 
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1984
>                 URL: https://issues.apache.org/jira/browse/WICKET-1984
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: James Perry
>            Priority: Minor
>             Fix For: 1.3.6
>
>
> More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1984.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC2

> MarkupContainer's add(final Component child) does not initially check for a child null reference 
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1984
>                 URL: https://issues.apache.org/jira/browse/WICKET-1984
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: James Perry
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.6, 1.4-RC2
>
>         Attachments: WICKET-1984.patch
>
>
> More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

Posted by "James Perry (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Perry updated WICKET-1984:
--------------------------------

    Attachment: WICKET-1984.patch

I can write test cases if needed.

> MarkupContainer's add(final Component child) does not initially check for a child null reference 
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1984
>                 URL: https://issues.apache.org/jira/browse/WICKET-1984
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: James Perry
>            Priority: Minor
>             Fix For: 1.3.6
>
>         Attachments: WICKET-1984.patch
>
>
> More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1984) MarkupContainer's add(final Component child) does not initially check for a child null reference

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1984:
-------------------------------------

    Assignee: Igor Vaynberg

> MarkupContainer's add(final Component child) does not initially check for a child null reference 
> -------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1984
>                 URL: https://issues.apache.org/jira/browse/WICKET-1984
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.5
>            Reporter: James Perry
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.6
>
>         Attachments: WICKET-1984.patch
>
>
> More specifically, the MarkupContainer's add(final Component child) calls checkHierarchyChange() before determining if the child reference is null. IMHO this should be ideally be called after checking if the child reference is null. From a user perspective, throwing an IllegalArgumentException with a message telling them that they have passed a null referenced component has better affordance then an esoteric NNE on calling checkHierarchyChange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.