You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/04 00:32:57 UTC
[GitHub] [incubator-tvm] kevinthesun opened a new pull request #5505: [ARITH][Canonical Simplifier]Fix FloorMod
kevinthesun opened a new pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505
In this [issue](https://discuss.tvm.ai/t/relay-fuse-fuse-generates-incorrect-result/6569), tvm StorageFlatten pass mess up indexing. The reason is that in Canonical Simplifier SplitModConst function, scale is not updated for updated SplitExpr.
@tqchen Could you take a look and make sure this is the appropriate fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5505: [ARITH][Canonical Simplifier]Fix FloorMod
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623531864
Thanks @kevinthesun I checked and it is indeed the correct fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5505: [ARITH][Canonical Simplifier]Fix FloorMod
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623531864
Thanks @kevinthesun I checked and it is indeed the correct fix. Thanks @junrushao1994 @Hzfengsy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5505: [BUGFIX][BACKPORT-0.6][ARITH] Fix FloorMod Simplifier
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623533282
@kevinthesun can you also send a PR to the 0.6 branch? Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] kevinthesun commented on pull request #5505: [BUGFIX][BACKPORT-0.6][ARITH] Fix FloorMod Simplifier
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623586158
> @kevinthesun can you also send a PR to the 0.6 branch? Thank you!
Sure will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5505: [ARITH][Canonical Simplifier]Fix FloorMod
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5505:
URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623271953
cc @yongfeng-nv @Hzfengsy @icemelon9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org