[GitHub] [inlong] dockerzhang commented on a diff in pull request #5873: [INLONG-5839][Sort] Add SortStandalone option in start script

[GitBox <gi...@apache.org>]

dockerzhang commented on code in PR #5873:
URL: https://github.com/apache/inlong/pull/5873#discussion_r990741060


##########
bin/inlong-daemon:
##########
@@ -32,6 +32,7 @@ command_help() {
     dashboard           Run a Dashboard Service
     dataproxy           Run a Dataproxy Service
     agent               Run a Agent Service
+    sortstandalone      Run a Sortstandalone Service

Review Comment:
   Run a Sortstandalone Service
   ->
   Run a Sort Standalone Service
   
   Since `Sortstandalone` is not a readable word.



##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
 # audit proxy IP
 audit_proxys_ip=127.0.0.1
 # audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+

Review Comment:
   a more empty line.



##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
 # audit proxy IP
 audit_proxys_ip=127.0.0.1
 # audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+
+############## SortStandalone Configuration ##############
+sortstandalone_ip=127.0.0.1
+sortstandalone_port=8088
+# sort-standalone config type, file or manager
+sortstandalone_config_type=file
+# sort-standalone config file name
+sortstandalone_config_file_name=SortClusterConfig.conf

Review Comment:
   'sortstandalone_config_file_name ' is redundant. It's better to remove it.



##########
bin/inlong-daemon:
##########
@@ -149,6 +158,8 @@ start_inlong_all() {
   start_inlong_dataproxy
   # start inlong agent
   start_inlong_agent
+  # start inlong sortstandalone
+  start_inlong_sortstandalone

Review Comment:
   start inlong sortstandalone
   ->
   start inlong sort standalone



##########
conf/inlong.conf:
##########
@@ -63,4 +63,14 @@ agent_port=8008
 # audit proxy IP
 audit_proxys_ip=127.0.0.1
 # audit proxy Port
-audit_proxys_port=10081
\ No newline at end of file
+audit_proxys_port=10081
+
+############## SortStandalone Configuration ##############
+sortstandalone_ip=127.0.0.1
+sortstandalone_port=8088
+# sort-standalone config type, file or manager

Review Comment:
   please add more information about the different types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org