You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "aurb9 (via GitHub)" <gi...@apache.org> on 2025/04/03 15:17:13 UTC
[I] ParquetSource should be tested [incubator-wayang]
aurb9 opened a new issue, #530:
URL: https://github.com/apache/incubator-wayang/issues/530
Add test similar to the JavaTextFileSourceTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ParquetSource should be tested [wayang]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #530:
URL: https://github.com/apache/wayang/issues/530#issuecomment-4039476909
Hi, I was exploring the Wayang repository and this issue looks like a good opportunity to improve test coverage.
I plan to add a unit test for `ParquetSource` similar to `JavaTextFileSourceTest`, including a small sample Parquet file under test resources to validate the read behavior.
If no one is currently working on this, I’d be happy to take it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ParquetSource should be tested [wayang]
Posted by "mspruc (via GitHub)" <gi...@apache.org>.
mspruc commented on issue #530:
URL: https://github.com/apache/wayang/issues/530#issuecomment-3949828849
@alisha-1000 Not sure that @aurb9 is still maintaining this, but yes a small parquet file sample in test resources should be sufficient for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ParquetSource should be tested [wayang]
Posted by "alisha-1000 (via GitHub)" <gi...@apache.org>.
alisha-1000 commented on issue #530:
URL: https://github.com/apache/wayang/issues/530#issuecomment-3929009294
I agree — adding a dedicated test for ParquetSource similar to JavaTextFileSourceTest would improve coverage and ensure consistent validation across source implementations.
I can work on adding:
A unit test mirroring the structure of JavaTextFileSourceTest
Validation of schema handling
Proper read behavior verification
Edge case scenarios (empty file, invalid schema, corrupted input if applicable)
Before proceeding, just to confirm:
Should the test use a small sample Parquet file placed under test resources?
Any specific scenarios you’d like covered beyond what JavaTextFileSourceTest already validates?
Happy to take this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org