You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2018/10/29 20:15:00 UTC

[jira] [Created] (IMPALA-7780) Rebase PlannerTest expected output for estimates, errors

Paul Rogers created IMPALA-7780:
-----------------------------------

             Summary: Rebase PlannerTest expected output for estimates, errors
                 Key: IMPALA-7780
                 URL: https://issues.apache.org/jira/browse/IMPALA-7780
             Project: IMPALA
          Issue Type: Improvement
          Components: Frontend
    Affects Versions: Impala 3.0
            Reporter: Paul Rogers


The front-end includes the {{PlannerTest}} test which works by running a query, writing the plan to a file, comparing selected parts of the file to expected results, and flagging if the results differ.

A plan includes some things we test (operators) and some we do not (text of error messages, value of memory estimates). Over time the expected and actual files have drifted apart. Example:

{noformat}
Expected:    partitions=1/1 files=2 size=54.20MB

Actual:      partitions=1/1 files=2 size=54.21MB
{noformat}

While the tests still pass (because we ignore the parts which have drifted), it is a pain to track down issues because we must learn to manually ignore "unimportant" differences.

This ticket asks to "rebase" planner tests on the latest results, copying into the expected results file the current "noise" values from the actual results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org