You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by an...@apache.org on 2019/05/08 21:46:57 UTC

[beam] branch master updated: [sql] fix non return bug.

This is an automated email from the ASF dual-hosted git repository.

anton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 92517ca  [sql] fix non return bug.
     new 2e3f921  Merge pull request #8532 from amaliujia/rw-fix_join_bug
92517ca is described below

commit 92517ca02fef76659798624305689bf7fcde664a
Author: amaliujia <am...@gmail.com>
AuthorDate: Wed May 8 14:11:52 2019 -0700

    [sql] fix non return bug.
---
 .../java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
index fe066e2..08a1a33 100644
--- a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
+++ b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
@@ -503,7 +503,7 @@ public class BeamJoinRel extends Join implements BeamRelNode {
       return schema.getField(((RexInputRef) rexNode).getIndex() - leftRowColumnCount);
     } else if (rexNode instanceof RexFieldAccess) {
       // need to extract field of Struct/Row.
-      getFieldBasedOnRexFieldAccess(schema, (RexFieldAccess) rexNode, leftRowColumnCount);
+      return getFieldBasedOnRexFieldAccess(schema, (RexFieldAccess) rexNode, leftRowColumnCount);
     }
 
     throw new UnsupportedOperationException("Does not support " + rexNode.getType() + " in JOIN.");