[GitHub] [helix] mgao0 commented on a diff in pull request #2390: Add API for users to provide customized threadpool for different categories of state transition messages

["mgao0 (via GitHub)" <gi...@apache.org>]

mgao0 commented on code in PR #2390:
URL: https://github.com/apache/helix/pull/2390#discussion_r1124882578


##########
helix-core/src/main/java/org/apache/helix/model/Message.java:
##########
@@ -115,6 +116,11 @@ public enum MessageState {
     UNPROCESSABLE // get exception when create handler
   }
 
+  public enum STRebalanceType {
+    LOAD_REBALANCE,
+    RECOVERY_REBALANCE
+  }
+

Review Comment:
   Yes, we have thought about reusing the RebalanceType in StateTransitionThrottleConfig class, but reusing it may cause confusion as this use case is not related to throttling. Separating it out may be an option, but the enum in StateTransitionThrottleConfig is widely used, and it will need a lot of code changes, overall it's not worthy to do it, so it is also not considered right now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org