You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/04 11:49:12 UTC
[GitHub] [incubator-ratis] lokeshj1703 opened a new pull request #86: RATIS-919. Exclude unwanted dependencies from hadoop dependency.
lokeshj1703 opened a new pull request #86:
URL: https://github.com/apache/incubator-ratis/pull/86
Apache jira: https://issues.apache.org/jira/browse/RATIS-919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] mukul1987 closed pull request #86: RATIS-919. Exclude unwanted dependencies from hadoop dependency.
Posted by GitBox <gi...@apache.org>.
mukul1987 closed pull request #86:
URL: https://github.com/apache/incubator-ratis/pull/86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] mukul1987 commented on a change in pull request #86: RATIS-919. Exclude unwanted dependencies from hadoop dependency.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #86:
URL: https://github.com/apache/incubator-ratis/pull/86#discussion_r420106954
##########
File path: ratis-logservice/src/test/java/org/apache/ratis/logservice/impl/TestArchiveHdfsLogReaderAndWriter.java
##########
@@ -39,11 +39,9 @@
import org.apache.ratis.logservice.api.ArchiveLogWriter;
import org.apache.ratis.logservice.api.LogName;
import org.apache.ratis.logservice.util.LogServiceUtils;
-import org.junit.AfterClass;
-import org.junit.Assert;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.*;
Review comment:
The patch looks good to me. Can you please expand this wildcard import ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org