You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/06/26 22:30:50 UTC
Re: Review Request 11488: Use string comparison for TaskID.
> On June 14, 2013, 8:57 p.m., Ben Mahler wrote:
> > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 778
> > <https://reviews.apache.org/r/11488/diff/3/?file=303684#file303684line778>
> >
> > Silly C++ programmers, thanks!
> >
> > Does the Java protobuf API generate .equals on the TaskID itself? (i.e. taskId.equals(...)). If so, let's use that.
Good idea!
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11488/#review21920
-----------------------------------------------------------
On June 11, 2013, 9:43 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11488/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 9:43 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use string comparison for TaskID.
>
> Review: https://reviews.apache.org/r/11488
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3
>
> Diff: https://reviews.apache.org/r/11488/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>