You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/20 12:33:00 UTC
Review Request 36614: LENS-670: Add log resource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/
-----------------------------------------------------------
Review request for lens and Himanshu Gahlaut.
Bugs: LENS-670
https://issues.apache.org/jira/browse/LENS-670
Repository: lens
Description
-------
Adds log resource which is added through configuration
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
lens-server/src/main/resources/lensserver-default.xml 2b540b8
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 3bcbf0e
lens-server/src/test/resources/log4j.properties e0f9daa
src/site/apt/admin/config.apt c5bf70c
src/site/apt/admin/deployment.apt 088a695
Diff: https://reviews.apache.org/r/36614/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36614: LENS-670: Add log resource
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 21, 2015, 5:10 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/LogResource.java, line 76
> > <https://reviews.apache.org/r/36614/diff/1/?file=1016652#file1016652line76>
> >
> > Can you take care of closing the input and output streams?
We cannot close the streams until they are consumned. Response takes care of closing them after response is consumed. See http://stackoverflow.com/questions/12012724/jersey-example-of-using-streamingoutput-as-response-entity or https://dzone.com/articles/jax-rs-streaming-response.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92372
-----------------------------------------------------------
On July 20, 2015, 11:17 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 11:17 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92372
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LogResource.java (line 76)
<https://reviews.apache.org/r/36614/#comment146501>
Can you take care of closing the input and output streams?
- Raju Bairishetti
On July 20, 2015, 11:17 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 11:17 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 20, 2015, 12:36 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java, line 163
> > <https://reviews.apache.org/r/36614/diff/1/?file=1016654#file1016654line163>
> >
> > IOUtils.copy does the same thing I think.
Nope. IOUtils copy is a full copy of the data. Where as pipe is streaming from output stream and putting into input stream - in chunks of 4096bytes. We are using same pipe for result download as well.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92262
-----------------------------------------------------------
On July 20, 2015, 11:17 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 11:17 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92262
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 163)
<https://reviews.apache.org/r/36614/#comment146326>
IOUtils.copy does the same thing I think.
- Rajat Khandelwal
On July 20, 2015, 4:47 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 4:47 p.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92385
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 21, 2015, 1:51 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 1:51 p.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/
-----------------------------------------------------------
(Updated July 21, 2015, 8:21 a.m.)
Review request for lens and Himanshu Gahlaut.
Changes
-------
Review comments fixed
Bugs: LENS-670
https://issues.apache.org/jira/browse/LENS-670
Repository: lens
Description
-------
Adds log resource which is added through configuration
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
lens-server/src/main/resources/lensserver-default.xml 2b540b8
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 3bcbf0e
lens-server/src/test/resources/log4j.properties e0f9daa
src/site/apt/admin/config.apt c5bf70c
src/site/apt/admin/deployment.apt 088a695
Diff: https://reviews.apache.org/r/36614/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
[INFO] Lens .............................................. SUCCESS [2.760s]
[INFO] Lens API .......................................... SUCCESS [20.260s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
[INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
[INFO] Lens DB storage ................................... SUCCESS [18.711s]
[INFO] Lens Query Library ................................ SUCCESS [16.986s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
[INFO] Lens Server ....................................... SUCCESS [5:05.445s]
[INFO] Lens client ....................................... SUCCESS [39.535s]
[INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
[INFO] Lens Examples ..................................... SUCCESS [8.755s]
[INFO] Lens Distribution ................................. SUCCESS [8.472s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
[INFO] Lens Regression ................................... SUCCESS [9.775s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:12.983s
[INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
[INFO] Final Memory: 192M/2361M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36614: LENS-670: Add log resource
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/#review92377
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LogResource.java (line 76)
<https://reviews.apache.org/r/36614/#comment146508>
Agree, but we can close input stream. Can we check StreamingOutput() in QueryExecutionServiceExecImpl class?
- Raju Bairishetti
On July 20, 2015, 11:17 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36614/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 11:17 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-670
> https://issues.apache.org/jira/browse/LENS-670
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds log resource which is added through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> lens-server/src/main/resources/lensserver-default.xml 2b540b8
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
> lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 3bcbf0e
> lens-server/src/test/resources/log4j.properties e0f9daa
> src/site/apt/admin/config.apt c5bf70c
> src/site/apt/admin/deployment.apt 088a695
>
> Diff: https://reviews.apache.org/r/36614/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
> [INFO] Lens .............................................. SUCCESS [2.760s]
> [INFO] Lens API .......................................... SUCCESS [20.260s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
> [INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
> [INFO] Lens DB storage ................................... SUCCESS [18.711s]
> [INFO] Lens Query Library ................................ SUCCESS [16.986s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
> [INFO] Lens Server ....................................... SUCCESS [5:05.445s]
> [INFO] Lens client ....................................... SUCCESS [39.535s]
> [INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
> [INFO] Lens Examples ..................................... SUCCESS [8.755s]
> [INFO] Lens Distribution ................................. SUCCESS [8.472s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
> [INFO] Lens Regression ................................... SUCCESS [9.775s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:12.983s
> [INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
> [INFO] Final Memory: 192M/2361M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36614: LENS-670: Add log resource
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36614/
-----------------------------------------------------------
(Updated July 20, 2015, 11:17 a.m.)
Review request for lens and Himanshu Gahlaut.
Bugs: LENS-670
https://issues.apache.org/jira/browse/LENS-670
Repository: lens
Description
-------
Adds log resource which is added through configuration
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/LogResource.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
lens-server/src/main/resources/lensserver-default.xml 2b540b8
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java a267fe0
lens-server/src/test/java/org/apache/lens/server/TestLogResource.java PRE-CREATION
lens-server/src/test/resources/lens-site.xml 3bcbf0e
lens-server/src/test/resources/log4j.properties e0f9daa
src/site/apt/admin/config.apt c5bf70c
src/site/apt/admin/deployment.apt 088a695
Diff: https://reviews.apache.org/r/36614/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.905s]
[INFO] Lens .............................................. SUCCESS [2.760s]
[INFO] Lens API .......................................... SUCCESS [20.260s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.299s]
[INFO] Lens Cube ......................................... SUCCESS [4:15.156s]
[INFO] Lens DB storage ................................... SUCCESS [18.711s]
[INFO] Lens Query Library ................................ SUCCESS [16.986s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:46.787s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.994s]
[INFO] Lens Server ....................................... SUCCESS [5:05.445s]
[INFO] Lens client ....................................... SUCCESS [39.535s]
[INFO] Lens CLI .......................................... SUCCESS [2:42.864s]
[INFO] Lens Examples ..................................... SUCCESS [8.755s]
[INFO] Lens Distribution ................................. SUCCESS [8.472s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.460s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.987s]
[INFO] Lens Regression ................................... SUCCESS [9.775s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:12.983s
[INFO] Finished at: Mon Jul 20 10:45:55 UTC 2015
[INFO] Final Memory: 192M/2361M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu