You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/01 14:39:04 UTC
[GitHub] [maven-linkcheck-plugin] elharo opened a new pull request #1:
[MLINKCHECK-36] update doxia and parent POM
elharo opened a new pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1
@hboutemy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] hboutemy commented on a change in pull
request #1: [MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r401752901
##########
File path: pom.xml
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugins</artifactId>
- <version>33</version>
+ <version>34</version>
Review comment:
upgrading parent is another story, and would be useful to add the project.build.outputTimestamp property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] elharo commented on a change in pull
request #1: [MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r403480328
##########
File path: pom.xml
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugins</artifactId>
- <version>33</version>
+ <version>34</version>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] hboutemy commented on a change in pull
request #1: [MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r401753413
##########
File path: pom.xml
##########
@@ -62,8 +62,8 @@ under the License.
</distributionManagement>
<properties>
- <doxiaVersion>1.4</doxiaVersion>
- <doxia-sitetoolsVersion>1.4</doxia-sitetoolsVersion>
+ <doxiaVersion>1.9.1</doxiaVersion>
+ <doxia-sitetoolsVersion>1.9.2</doxia-sitetoolsVersion>
Review comment:
I did not try to run, but yes, it should be as siple as that: that's why the issue was marked as up-for-grabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] elharo merged pull request #1:
[MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] elharo commented on a change in pull
request #1: [MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r409542510
##########
File path: pom.xml
##########
@@ -62,11 +62,11 @@ under the License.
</distributionManagement>
<properties>
- <doxiaVersion>1.4</doxiaVersion>
- <doxia-sitetoolsVersion>1.4</doxia-sitetoolsVersion>
+ <doxiaVersion>1.9.1</doxiaVersion>
+ <doxia-sitetoolsVersion>1.9.2</doxia-sitetoolsVersion>
<mavenVersion>2.2.1</mavenVersion>
<javaVersion>7</javaVersion>
- <project.build.outputTimestamp>2020-04-07T21:04:00Z</project.build.outputTimestamp>
+<project.build.outputTimestamp>2020-04-04T16:07:00Z</project.build.outputTimestamp>
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-linkcheck-plugin] michael-o commented on a change in pull
request #1: [MLINKCHECK-36] update doxia and parent POM
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #1: [MLINKCHECK-36] update doxia and parent POM
URL: https://github.com/apache/maven-linkcheck-plugin/pull/1#discussion_r407445141
##########
File path: pom.xml
##########
@@ -62,11 +62,11 @@ under the License.
</distributionManagement>
<properties>
- <doxiaVersion>1.4</doxiaVersion>
- <doxia-sitetoolsVersion>1.4</doxia-sitetoolsVersion>
+ <doxiaVersion>1.9.1</doxiaVersion>
+ <doxia-sitetoolsVersion>1.9.2</doxia-sitetoolsVersion>
<mavenVersion>2.2.1</mavenVersion>
<javaVersion>7</javaVersion>
- <project.build.outputTimestamp>2020-04-07T21:04:00Z</project.build.outputTimestamp>
+<project.build.outputTimestamp>2020-04-04T16:07:00Z</project.build.outputTimestamp>
Review comment:
Broken formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services