[GitHub] [johnzon] jungm commented on a diff in pull request #100: Implement JSON-B 3 Polymorphism

["jungm (via GitHub)" <gi...@apache.org>]

jungm commented on code in PR #100:
URL: https://github.com/apache/johnzon/pull/100#discussion_r1170082537


##########
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/MapperConfig.java:
##########
@@ -98,6 +98,8 @@ public Object fromJson(JsonValue jsonObject, Type targetType, MappingParser pars
 
     private final SnippetFactory snippet;
 
+    private final Function<MapperConfig, Mappings> mappingsFactory;
+
     //CHECKSTYLE:OFF
     @Deprecated
     public MapperConfig(final LazyConverterMap adapters,

Review Comment:
   Is it okay to touch the other constructor of MapperConfig? (the one not used in ExtendMappingTest)
   Or do I add a third one and mark the current non-deprecated one as deprecated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org