[GitHub] [doris] morningman commented on a diff in pull request #15035: [feature](file reader) Merge stream_load_pipe to the new file reader

[GitBox <gi...@apache.org>]

morningman commented on code in PR #15035:
URL: https://github.com/apache/doris/pull/15035#discussion_r1048012467


##########
be/src/io/fs/stream_load_pipe_reader.h:
##########
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <condition_variable>
+#include <deque>
+
+#include "io/fs/file_reader.h"
+#include "runtime/message_body_sink.h"
+
+namespace doris {
+namespace io {
+
+const size_t kMaxPipeBufferedBytes = 4 * 1024 * 1024;
+
+class StreamLoadPipeReader : public MessageBodySink, public FileReader {

Review Comment:
   ```suggestion
   class StreamLoadPipe : public MessageBodySink, public FileReader {
   ```
   
   Because it is not just a "Reader"
   



##########
be/src/runtime/routine_load/kafka_consumer_pipe_reader.h:
##########
@@ -0,0 +1,50 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "io/fs/stream_load_pipe_reader.h"
+
+namespace doris {
+namespace io {
+class KafkaConsumerPipeReader : public StreamLoadPipeReader {

Review Comment:
   ```suggestion
   class KafkaConsumerPipe : public StreamLoadPipeReader {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org