You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/05/17 04:58:31 UTC
[GitHub] incubator-gearpump pull request #183: [GEARPUMP-312] Add Message trait and D...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/183
[GEARPUMP-312] Add Message trait and DefaultMessage impl
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump message_trait
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 7450c4e643d339660fb3cd4d901a773779f4be8f
Author: manuzhang <ow...@gmail.com>
Date: 2017-05-17T04:57:38Z
[GEARPUMP-312] Add Message trait and DefaultMessage impl
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #183: [GEARPUMP-312] Add Message trait and D...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/183
Can we and should we add an apply function in trait Message's companion object which returns a `DefaultMessage`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/183
@huafengw updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/183
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #183: [GEARPUMP-312] Add Message trait and D...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/183#discussion_r117160623
--- Diff: integrationtest/core/src/it/scala/org/apache/gearpump/integrationtest/checklist/DefaultMessageDeliverySpec.scala ---
@@ -28,7 +28,7 @@ import org.apache.gearpump.integrationtest.{TestSpecBase, Util}
/**
* Checks message delivery consistency, like at-least-once, and exactly-once.
*/
-class MessageDeliverySpec extends TestSpecBase {
+class DefaultMessageDeliverySpec extends TestSpecBase {
--- End diff --
Do we need to change this name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #183: [GEARPUMP-312] Add Message trait and D...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/183#discussion_r117160807
--- Diff: integrationtest/core/src/it/scala/org/apache/gearpump/integrationtest/checklist/DefaultMessageDeliverySpec.scala ---
@@ -28,7 +28,7 @@ import org.apache.gearpump.integrationtest.{TestSpecBase, Util}
/**
* Checks message delivery consistency, like at-least-once, and exactly-once.
*/
-class MessageDeliverySpec extends TestSpecBase {
+class DefaultMessageDeliverySpec extends TestSpecBase {
--- End diff --
oh, my IDE is to blame for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/183
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=h1) Report
> Merging [#183](https://codecov.io/gh/apache/incubator-gearpump/pull/183?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/000e846ab227a2113a182b5d6917724f128cb63a?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `79.41%`.
```diff
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 71.6% 71.64% +0.04%
==========================================
Files 191 191
Lines 6082 6084 +2
Branches 524 521 -3
==========================================
+ Hits 4355 4359 +4
+ Misses 1727 1725 -2
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #183: [GEARPUMP-312] Add Message trait and DefaultM...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/183
Document update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---