You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "lukaszzborek (via GitHub)" <gi...@apache.org> on 2026/10/16 18:31:36 UTC
[PR] chore(csharp): remove FluentAssertions from tests [iggy]
lukaszzborek opened a new pull request, #4578:
URL: https://github.com/apache/iggy/pull/4578
The C# unit tests referenced FluentAssertions 8, which is released under
the Xceed Community License rather than an open source license. Only
IggyTypedPublisherTests used it, while the other unit tests already
rely on xUnit Assert.
The assertions in IggyTypedPublisherTests now use xUnit Assert, and the
FluentAssertions package is removed from Directory.Packages.props and
the test project. BeEquivalentTo maps to Assert.Equivalent in strict
mode, so order still does not matter but extra items fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): remove FluentAssertions from tests [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4578:
URL: https://github.com/apache/iggy/pull/4578#issuecomment-6222464740
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4578?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 89.07%. Comparing base ([`83b3664`](https://app.codecov.io/gh/apache/iggy/commit/83b3664a1c7b4846533065ed912a886bb8673915?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6963926`](https://app.codecov.io/gh/apache/iggy/commit/6963926bf73e956f8a1d37eb57dc045ed16317ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4578 +/- ##
============================================
- Coverage 89.52% 89.07% -0.45%
Complexity 1785 1785
============================================
Files 1330 1330
Lines 286764 286764
Branches 245211 245211
============================================
- Hits 256721 255446 -1275
- Misses 24398 25713 +1315
+ Partials 5645 5605 -40
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.75% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.42% <ø> (-13.04%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.43% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.02% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.12% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.86% <ø> (ø)` | |
| [C++ SDK](https://app.codecov.io/gh/apache/iggy/pull/4578/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.44% <ø> (ø)` | |
[see 46 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4578/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): remove FluentAssertions from tests [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #4578:
URL: https://github.com/apache/iggy/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org