[GitHub] [beam] pabloem commented on a change in pull request #12782: Overriding Dataflow Native BQSource.

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r493031855



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -168,7 +168,8 @@ def test_invalid_json_neg_inf(self):
 @unittest.skipIf(HttpError is None, 'GCP dependencies are not installed')
 class TestBigQuerySource(unittest.TestCase):
   def test_display_data_item_on_validate_true(self):
-    source = beam.io.BigQuerySource('dataset.table', validate=True)
+    source = beam.io.BigQuerySource(

Review comment:
       Tests in this file use the native BQ source implementation (e.g. specific display data, using the Reader implementation used for DirectRunner, etc. I think after deprecation, most of the tests in this particular class would go away) - integration tests are not having to change almost at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org