You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2007/10/03 19:37:56 UTC

Re: [PATCH] [RFC] Require Autoconf >=2.58

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

2007-09-30 11:30:56 Max Bowsher napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > Hello,
> > 
> > I would like to propose to increase Autoconf version requirement to >=2.58.
> > Autoconf 2.58 was released on 2003-11-04 ([1]), so probably everybody has this
> > version or newer.
> 
> I am in favour of this. I doubt that we've actually been testing to make
> sure that we comply with our current declared requirement of >=2.50, and
> I don't think that there's any value in attempting to maintain extreme
> compatibility for a dependency only required for running ./autogen.sh .

So you could anybody commit this simple patch?
Apparently nobody is against it.

- -- 
Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)

iD8DBQFHA+/2/axNJ4Xo/ZERAuo3AJ9NPNCrXLlKJdm+HJWDcmRax7WzNwCghYEf
0CCdPIH7PLZVQG8TTlcWQxI=
=qcgv
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] [RFC] Require Autoconf >=2.58

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

2007-10-06 05:40:49 Max Bowsher napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > [[[
> > Require Autoconf >=2.58 and replace some deprecated Autoconf macros with not
> > deprecated ones.
> > 
> > * configure.in
> >   (AC_PREREQ): Require Autoconf >=2.58.
> > 
> > * configure.in
> > * build/ac-macros/apache.m4
> > * build/ac-macros/java.m4
> > * build/ac-macros/neon.m4
> > * build/ac-macros/serf.m4
> > * build/ac-macros/sqlite.m4
> > * build/ac-macros/svn-macros.m4
> > * build/ac-macros/swig.m4
> > * build/ac-macros/zlib.m4
> >   Replace uses of AC_HELP_STRING with AS_HELP_STRING.
> > 
> > * build/ac-macros/apache.m4
> > * build/ac-macros/berkeley-db.m4
> > * build/ac-macros/find_apr.m4
> > * build/ac-macros/find_apu.m4
> > * build/ac-macros/sasl.m4
> >   Use AS_HELP_STRING.
> > 
> > * build/ac-macros/berkeley-db.m4
> >   Replace use of AC_TRY_RUN with AC_RUN_IFELSE and AC_LANG_SOURCE.
> > 
> > * build/ac-macros/svn-macros.m4
> >   Replace use of AC_TRY_COMPILE with AC_COMPILE_IFELSE and AC_LANG_PROGRAM.
> > 
> > Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
> > ]]]
> 
> I've started to apply this.
> 
> I assume the extra quoting introduced in the patch around the outside of
> the AS_HELP_STRING invocations is just following general autoconf
> guidelines? Or is it fixing something in particular?

General autoconf guidelines.

- -- 
Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)

iD8DBQFHB6xd/axNJ4Xo/ZERAicGAKCaQAh2H7KQNArfPSIYmTnG/YCWxQCeL7NF
erljL7sgxrojdOyoQw3pqII=
=Bnvc
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] [RFC] Require Autoconf >=2.58

Posted by Max Bowsher <ma...@ukf.net>.
Arfrever Frehtes Taifersar Arahesis wrote:
> I'm attaching the remaining part of this patch.
> 
> [[[
> Introduce AS_HELP_STRING use where it was missing.
> 
> * build/ac-macros/find_apr.m4
> * build/ac-macros/find_apu.m4
> 
> Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
> ]]]

Ah, yes.

Sorry, I should have replied earlier - I deliberately did not apply
those changes, because those two files are not actually maintained by
the Subversion Project - they are actually maintained by the APR
Project, and copied into Subversion from the APR and APR-util source trees.

Max.


Re: [PATCH] [RFC] Require Autoconf >=2.58

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
I'm attaching the remaining part of this patch.

[[[
Introduce AS_HELP_STRING use where it was missing.

* build/ac-macros/find_apr.m4
* build/ac-macros/find_apu.m4

Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
]]]

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] [RFC] Require Autoconf >=2.58

Posted by Max Bowsher <ma...@ukf.net>.
Arfrever Frehtes Taifersar Arahesis wrote:
> [[[
> Require Autoconf >=2.58 and replace some deprecated Autoconf macros with not
> deprecated ones.
> 
> * configure.in
>   (AC_PREREQ): Require Autoconf >=2.58.
> 
> * configure.in
> * build/ac-macros/apache.m4
> * build/ac-macros/java.m4
> * build/ac-macros/neon.m4
> * build/ac-macros/serf.m4
> * build/ac-macros/sqlite.m4
> * build/ac-macros/svn-macros.m4
> * build/ac-macros/swig.m4
> * build/ac-macros/zlib.m4
>   Replace uses of AC_HELP_STRING with AS_HELP_STRING.
> 
> * build/ac-macros/apache.m4
> * build/ac-macros/berkeley-db.m4
> * build/ac-macros/find_apr.m4
> * build/ac-macros/find_apu.m4
> * build/ac-macros/sasl.m4
>   Use AS_HELP_STRING.
> 
> * build/ac-macros/berkeley-db.m4
>   Replace use of AC_TRY_RUN with AC_RUN_IFELSE and AC_LANG_SOURCE.
> 
> * build/ac-macros/svn-macros.m4
>   Replace use of AC_TRY_COMPILE with AC_COMPILE_IFELSE and AC_LANG_PROGRAM.
> 
> Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
> ]]]

I've started to apply this.

I assume the extra quoting introduced in the patch around the outside of
the AS_HELP_STRING invocations is just following general autoconf
guidelines? Or is it fixing something in particular?

Max.


Re: [PATCH] [RFC] Require Autoconf >=2.58

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2007-10-03 21:37:33 Arfrever Frehtes Taifersar Arahesis napisał(a):
> 2007-09-30 11:30:56 Max Bowsher napisał(a):
> > Arfrever Frehtes Taifersar Arahesis wrote:
> > > Hello,
> > >
> > > I would like to propose to increase Autoconf version requirement to >=2.58.
> > > Autoconf 2.58 was released on 2003-11-04 ([1]), so probably everybody has this
> > > version or newer.
> >
> > I am in favour of this. I doubt that we've actually been testing to make
> > sure that we comply with our current declared requirement of >=2.50, and
> > I don't think that there's any value in attempting to maintain extreme
> > compatibility for a dependency only required for running ./autogen.sh .
> 
> So you could anybody commit this simple patch?
> Apparently nobody is against it.

I'm attaching the updated version of this simple patch.

[[[
Require Autoconf >=2.58 and replace some deprecated Autoconf macros with not
deprecated ones.

* configure.in
  (AC_PREREQ): Require Autoconf >=2.58.

* configure.in
* build/ac-macros/apache.m4
* build/ac-macros/java.m4
* build/ac-macros/neon.m4
* build/ac-macros/serf.m4
* build/ac-macros/sqlite.m4
* build/ac-macros/svn-macros.m4
* build/ac-macros/swig.m4
* build/ac-macros/zlib.m4
  Replace uses of AC_HELP_STRING with AS_HELP_STRING.

* build/ac-macros/apache.m4
* build/ac-macros/berkeley-db.m4
* build/ac-macros/find_apr.m4
* build/ac-macros/find_apu.m4
* build/ac-macros/sasl.m4
  Use AS_HELP_STRING.

* build/ac-macros/berkeley-db.m4
  Replace use of AC_TRY_RUN with AC_RUN_IFELSE and AC_LANG_SOURCE.

* build/ac-macros/svn-macros.m4
  Replace use of AC_TRY_COMPILE with AC_COMPILE_IFELSE and AC_LANG_PROGRAM.

Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
]]]

-- 
Arfrever Frehtes Taifersar Arahesis