You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2010/04/13 21:18:50 UTC
[jira] Created: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
JDBC metadata gives incorrect lengths for timestamps
----------------------------------------------------
Key: DERBY-4614
URL: https://issues.apache.org/jira/browse/DERBY-4614
Project: Derby
Issue Type: Bug
Components: SQL
Affects Versions: 10.6.0.0
Reporter: Rick Hillegas
While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
C.S. Nirmal J. Fernando reassigned DERBY-4614:
----------------------------------------------
Assignee: C.S. Nirmal J. Fernando
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903957#action_12903957 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Hi Rick,
I would like to take up this bug. I've read through the specification that you've attached.
Can you suggest me an entry point to implement the spec? I can see that solving this bug,
will help to solve the other linked bugs.
Thanks.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904639#action_12904639 ]
Rick Hillegas commented on DERBY-4614:
--------------------------------------
Hi Nirmal,
I don't have a comprehensive list of tests which stress the metadata calls so I would recommend running the full regression test suite. Before doing that, though, I would recommend running the following tests standalone:
DatabaseMetaDataTest
TestDbMetaData
ParameterMetaDataJdbc30Test
ResultSetMetaDataTest
PrepStmtMetaDataTest
In addition, I would recommend running the upgrade tests because they test the metadata in old versions of Derby and you will want to make sure that they don't break when you change the metadata in 10.7.
Thanks,
-Rick
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905514#action_12905514 ]
Kathey Marsden commented on DERBY-4614:
---------------------------------------
Hi Nirmal,
I haven't had a chance to look at the patch, but i know earlier you asked about specific tests for database metadata. Traditionally one area of concern regrarding these queries has been upgrade because they are stored in the database. Hopefully we have that worked out with the fix for DERBY-1107,
I believe the upgrade tests test test metadata make sure that everything behaves properly. But it would be interesting to do some ad hoc testing around soft upgrade, particularly with maintenance versions around your changes.
Thanks
Kathey
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904192#action_12904192 ]
Rick Hillegas commented on DERBY-4614:
--------------------------------------
Hi Nirmal,
In addition to Bryan's suggestions, you'll want to take a look at metadata.properties. That file contains the queries which support the DatabaseMetaData calls. Thanks.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904627#action_12904627 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Hi,
Is there a way to find tests involved with database metadata? or the better way is, make my changes run java -Xmx512m -XX:MaxPermSize=128m junit.textui.TestRunner org.apache.derbyTesting.functionTests.suites.All >junitAll.out 2>&1 and see the failures and change the tests?
PS: I'm not sure whether running only java -Xmx512m -XX:MaxPermSize=128m junit.textui.TestRunner org.apache.derbyTesting.functionTests.suites.All >junitAll.out 2>&1 will be enough. Please suggest me if not.
Thanks.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905481#action_12905481 ]
Knut Anders Hatlen commented on DERBY-4614:
-------------------------------------------
A couple comments to the parts of the patch that affects this issue:
1) I don't think we can change DRDAConstants.DRDA_TIMESTAMP_LENGTH
from 26 to 29. This constant needs to stay at 26 to ensure that newer
servers can talk to old clients after the DERBY-2602 changes. It is
not used by any of the meta-data calls, as far as I know, so I think
it is safe to leave this change out. You may want to run the
compatibility tests to verify that we don't break compatibility. See
java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/README.html
for details on how to set up and run these tests.
2) We have this code in ColumnMetaData.getScale():
// We get the scale from the SQLDA as returned by DERBY, but DERBY does not return the ANSI-defined
// value of scale 6 for TIMESTAMP.
//
// The JDBC drivers should hardcode this info as a short/near term solution.
//
if (types_[column - 1] == Types.TIMESTAMP) {
return 6;
}
return sqlScale_[column - 1];
The patch changes this code to return 9 in the case of a timestamp,
which I think is fine, but I'm wondering if the special case for
timestamp could be removed now that we make the embedded driver return
9 from its getScale() method. I think the value in sqlScale_[column-1]
comes from the embedded driver, but we need to check that.
3) I see that the existing tests have been updated, and those changes
look fine to me. But do we also need new test cases to cover all the
changes listed in the functional spec? I see that the existing tests
cover these methods with the timestamp type:
DatabaseMetaData.getTypeInfo()
DatabaseMetaData.getProcedureColumns()
DatabaseMetaData.getFunctionColumns()
ResultSetMetaData.getColumnDisplaySize()
ResultSetMetaData.getPrecision()
ResultSetMetaData.getScale()
But I couldn't find that we test ParameterMetaData.getPrecision() and
ParameterMetaData.getScale() with timestamp anywhere. Do you think it
would be worthwhile to add tests for those two methods?
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903975#action_12903975 ]
Bryan Pendleton commented on DERBY-4614:
----------------------------------------
Some good places to start might include:
1) Setting up java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ResultSetMiscTest.java
in your debugger, so that you can have an easy way to set breakpoints in various
metadata methods and hit them from the test.
2) Have a look at
java/engine/org/apache/derby/impl/jdbc/EmbedResultSetMetaData.java
and
java/engine/org/apache/derby/iapi/types/DataTypeUtilities.java
to get a feel for how some of the RSMD methods are implemented for embedded Derby
3) Have a look at
java/client/org/apache/derby/client/am/ColumnMetaData.java
to get a feel for how some of the RSMD methods are implemented for client/server Derby
Then I'd suggest having a close look through the spec and ensuring that
the existing test programs provide reasonable test coverage for the API calls of interest.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4614:
---------------------------------
Issue & fix info: [Newcomer]
This seems like a good issue for a newcomer. This issue is a good introduction to how Derby's JDBC metadata is implemented and tested.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4614:
---------------------------------
Attachment: derby-4614-fs.html
Attaching functional spec for the metadata changes.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905483#action_12905483 ]
Knut Anders Hatlen commented on DERBY-4614:
-------------------------------------------
I ran the regression tests with the patch, and these three tests failed for me in derbyall:
derbyall/derbyall.fail:lang/compressTable.sql
derbyall/derbyall.fail:lang/specjPlans.sql
derbyall/derbyall.fail:lang/triggerRefClause.sql
It looks like all failures were caused by ij giving more space to timestamp columns, so we just need to update the master files.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-4614:
--------------------------------------
Issue & fix info: [Newcomer] (was: [Patch Available, Newcomer])
>From the comments it sounds like the patch is not quite ready yet, so I'm removing the Patch Available flag.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Attachments: derby-4614-1.diff, derby-4614-fs.html, derby_4614-2.diff
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
C.S. Nirmal J. Fernando updated DERBY-4614:
-------------------------------------------
Attachment: derby_4614-2.diff
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html, derby_4614-2.diff
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905467#action_12905467 ]
Knut Anders Hatlen commented on DERBY-4614:
-------------------------------------------
Hi Nirmal,
It looks to me that this issue and DERBY-4625 are orthogonal issues that would be better addressed separately. What are the problems you have found that made them difficult to separate? To me it looks like the changes in SQLTimestamp.java and DateTimeTest.java are only related to DERBY-4625, and the changes in the other files are only related to this issue. Would that be a reasonable way to split the patch?
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904223#action_12904223 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Thanks Bryan & Rick! I'll look into those.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905509#action_12905509 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Hi Knut,
Regarding your first comment, when I remove those changes earlier I got some test failures in DateTimeTest. But now I can't reproduce them. So I'll provide separate patches.
Thanks for pointing that out.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
C.S. Nirmal J. Fernando updated DERBY-4614:
-------------------------------------------
Issue & fix info: [Newcomer, Patch Available] (was: [Newcomer])
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
C.S. Nirmal J. Fernando updated DERBY-4614:
-------------------------------------------
Attachment: derby-4614-1.diff
Hi,
I am attaching patch #1 which is intended to implement the spec of this issue.
Additionally this patch is addressing derby-4625 as well, both are co-related
so difficult to separate.
I ran the full regression test suite successfully!
Thanks.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910546#action_12910546 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Hi,
I've separated the derby-4625 issue related changes from this issue, in patch #2.
But I couldn't find any time to look at Knut's 2) & 3) points in his one before last comment.
I've unassigned my self from this issue since I've to concentrate on my final year research project.
Things to be done:
1) Run regression tests on new patch
2) Consider Knut's above mentioned 2nd & 3rd points
Thanks for all the help provided on this issue!
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html, derby_4614-2.diff
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-4614) JDBC metadata gives incorrect lengths
for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
C.S. Nirmal J. Fernando reassigned DERBY-4614:
----------------------------------------------
Assignee: (was: C.S. Nirmal J. Fernando)
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Attachments: derby-4614-1.diff, derby-4614-fs.html, derby_4614-2.diff
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-4614) JDBC metadata gives
incorrect lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905178#action_12905178 ]
C.S. Nirmal J. Fernando edited comment on DERBY-4614 at 9/1/10 3:39 PM:
------------------------------------------------------------------------
Hi,
I am attaching patch #1 which is intended to implement the spec of this issue.
Additionally this patch is addressing DERBY-4625 as well, both are co-related
so difficult to separate.
I ran the full regression test suite successfully!
Thanks.
was (Author: nirmal):
Hi,
I am attaching patch #1 which is intended to implement the spec of this issue.
Additionally this patch is addressing derby-4625 as well, both are co-related
so difficult to separate.
I ran the full regression test suite successfully!
Thanks.
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4614) JDBC metadata gives incorrect
lengths for timestamps
Posted by "C.S. Nirmal J. Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905533#action_12905533 ]
C.S. Nirmal J. Fernando commented on DERBY-4614:
------------------------------------------------
Hi Knut,
Regarding your second comment,
1) I found that in java/engine/org/apache/derby/iapi/types/TypeId.java we use "public static final int TIMESTAMP_MAXWIDTH = DRDAConstants.DRDA_TIMESTAMP_LENGTH; // yyyy-mm-dd hh:mm:ss.fffffffff".
2) I'll look into it.
3) I'll add some tests.
Regarding your third comment,
Sorry about that I did not run derbyall previously, I'll update those tests soon, thanks for running tests Knut!
Thanks again for quick reviews!
> JDBC metadata gives incorrect lengths for timestamps
> ----------------------------------------------------
>
> Key: DERBY-4614
> URL: https://issues.apache.org/jira/browse/DERBY-4614
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Assignee: C.S. Nirmal J. Fernando
> Attachments: derby-4614-1.diff, derby-4614-fs.html
>
>
> While looking into DERBY-2602, I noticed that Derby gives the wrong lengths for various fields in the JDBC metadata for timestamps. I will attach a spec describing what I think should be done to correct this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.