You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/06/15 11:14:42 UTC
[09/34] git commit: updated refs/heads/master to 7a57ce3
Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
This closes #416
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/89a07084
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/89a07084
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/89a07084
Branch: refs/heads/master
Commit: 89a07084c55aee97c4ebcbb3e5021e5e4e384d11
Parents: 4e0fe46
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 16:28:37 2015 +0200
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Jun 15 12:09:22 2015 +0300
----------------------------------------------------------------------
.../apache/cloudstack/framework/transport/TransportAddress.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/89a07084/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java
----------------------------------------------------------------------
diff --git a/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java b/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java
index 4a724fd..99e25b1 100644
--- a/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java
+++ b/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java
@@ -19,7 +19,7 @@
package org.apache.cloudstack.framework.transport;
-import java.util.Random;
+import java.security.SecureRandom;
public class TransportAddress {
public final static String LOCAL_SERVICE_NODE = "";
@@ -29,6 +29,7 @@ public class TransportAddress {
private int _connectionId = LOCAL_SERVICE_CONNECTION;
private String _endpointId;
private int _magic;
+ private final SecureRandom randomGenerator=new SecureRandom();
public TransportAddress(String nodeId, int connectionId, String endpointId) {
assert (nodeId != null);
@@ -39,7 +40,7 @@ public class TransportAddress {
_nodeId = nodeId;
_connectionId = connectionId;
_endpointId = endpointId;
- _magic = new Random().nextInt();
+ _magic = randomGenerator.nextInt();
}
public TransportAddress(String nodeId, int connectionId, String endpointId, int magic) {