[GitHub] [superset] AAfghahi commented on a diff in pull request #21303: chore: add test for SPA explore endpoints around missing datasets

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #21303:
URL: https://github.com/apache/superset/pull/21303#discussion_r966353792


##########
tests/unit_tests/explore/api_test.py:
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any
+
+import pytest
+
+
+def test_explore_datasource_not_found(client: Any, full_api_access: None) -> None:
+    # validating the payload for a dataset that doesn't exist
+    # user should be expecting missing_datasource view
+    response = client.get(
+        "/api/v1/explore/?dataset_id=50000&dataset_type=table",
+    )
+    response.json["result"]["dataset"]["name"] == "[Missing Dataset]"
+    assert response.status_code == 200

Review Comment:
   Yeah same question. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org