You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "Nicklee007 (via GitHub)" <gi...@apache.org> on 2023/03/13 08:02:32 UTC
[GitHub] [bookkeeper] Nicklee007 opened a new pull request, #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions
Nicklee007 opened a new pull request, #3860:
URL: https://github.com/apache/bookkeeper/pull/3860
### Motivation
After PR #3056 , Bookkeeper set `level_compaction_dynamic_level_bytes=true` as `TableOptions` in `entry_location_rocksdb.conf.default` , which will cause `level_compaction_dynamic_level_bytes` lose efficacy and will cause rocksDB .sst file compact sort chaos when update bookie release.
As RocksDB conf, `level_compaction_dynamic_level_bytes` need set as `CFOptions` https://github.com/facebook/rocksdb/blob/master/examples/rocksdb_option_file_example.ini
<img width="703" alt="image" src="https://user-images.githubusercontent.com/84127069/224640399-d5481fe5-7b75-4229-ac06-3d280aa9ae6d.png">
<img width="240" alt="image" src="https://user-images.githubusercontent.com/84127069/224640621-737d0a42-4e01-4f38-bd5a-862a93bc4b32.png">
### Changes
1. Change `level_compaction_dynamic_level_bytes=true` from `TableOptions` to `CFOptions` in `entry_location_rocksdb.conf.default` ;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions
Posted by "Nicklee007 (via GitHub)" <gi...@apache.org>.
Nicklee007 commented on PR #3860:
URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1466075974
> entry_location_rocksdb.conf also has the problem.
@horizonzy Modify the test_entry_location_rocksdb.conf & entry_location_rocksdb.conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #3860:
URL: https://github.com/apache/bookkeeper/pull/3860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions
Posted by "Nicklee007 (via GitHub)" <gi...@apache.org>.
Nicklee007 commented on PR #3860:
URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1467294240
> Would you please add a test to check whether the parameter has been set correctly?
@hangc0276 add some unit test, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3860:
URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1465737664
## [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3860](https://codecov.io/gh/apache/bookkeeper/pull/3860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (131b1c1) into [master](https://codecov.io/gh/apache/bookkeeper/commit/06c3cabde7e311666837598c2b8ebd1a8aa00efc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06c3cab) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3860 +/- ##
============================================
+ Coverage 68.33% 68.35% +0.01%
- Complexity 6770 6771 +1
============================================
Files 473 473
Lines 40982 40987 +5
Branches 5241 5243 +2
============================================
+ Hits 28005 28015 +10
+ Misses 10722 10718 -4
+ Partials 2255 2254 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `39.81% <ø> (+0.02%)` | :arrow_up: |
| client | `44.17% <ø> (-0.04%)` | :arrow_down: |
| remaining | `29.49% <ø> (-0.02%)` | :arrow_down: |
| replication | `41.33% <ø> (-0.04%)` | :arrow_down: |
| tls | `21.01% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 34 files with indirect coverage changes](https://codecov.io/gh/apache/bookkeeper/pull/3860/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org