You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2011/05/17 10:14:47 UTC
[jira] [Created] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Rename FieldsConsumer to InvertedFieldsConsumer
-----------------------------------------------
Key: LUCENE-3109
URL: https://issues.apache.org/jira/browse/LUCENE-3109
Project: Lucene - Java
Issue Type: Task
Components: core/codecs
Affects Versions: 4.0
Reporter: Simon Willnauer
Priority: Minor
Fix For: 4.0
The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3109:
---------------------------------------
Attachment: LUCENE-3109.patch
Hi Iulius,
Here's my current patch -- it doesn't compile because of the missing renamed sources but possibly from other things (eg if I messed up any of the merging). But hopefully it's close :) Thanks!
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035510#comment-13035510 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
+1
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Iulius Curt updated LUCENE-3109:
--------------------------------
Attachment: LUCENE-3109.patch
bq. Should we change AtomicReader to have invertedField() instead fields()?
I worked out all the {{fields()}} methods that returned {{InvertedFields}}.
Also {{MIGRATE.txt}}
bq. Also the name FieldsEnum is now inconsistent.
This is not included in the patch because I have some difficulty deciding whether or not also rename all the classes derived from {{FieldsEnum}} (like {{FilterAtomicReader.FilterFieldsEnum}})
Also, should {{MultiFields}} and {{MultiFieldsEnum}} get renamed?
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209309#comment-13209309 ]
Simon Willnauer commented on LUCENE-3109:
-----------------------------------------
bq. Is this still valid? (It looks like a good place for me to enter the community)
I think so there should also be an InvertedFieldsProducer
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249512#comment-13249512 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
Thanks Iulius, looks great! I'll commit...
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249237#comment-13249237 ]
Iulius Curt commented on LUCENE-3109:
-------------------------------------
Good question. It seems I didn't add the renamed sources.
Could you please upload the patch with the shifted-code-conflicts you mentioned about solved?
This would be wonderful, I could much easily redo only the renamed sources.
Thanks for your feedback.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249544#comment-13249544 ]
Robert Muir commented on LUCENE-3109:
-------------------------------------
Can we please revert the renaming of Fields to InvertedFields?
The title of this issue made me think it only affects low-level codec apis but now
we are talking about a massive renaming of postings apis that, in my opinion,
goes in the wrong direction, and in the least requires more discussion.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Iulius Curt updated LUCENE-3109:
--------------------------------
Attachment: LUCENE-3109.patch
Repaired a foolish mistake.
Also limited to the classes sepcified in the ticket.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249546#comment-13249546 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
OK I'll revert so we can discuss more...
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249390#comment-13249390 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
Thanks for the fast turnaround Iulius!
Did you use "svn mv" to rename the sources? (I'm guessing not -- I don't see the removed original sources).
But it's fine: I got this to apply quite easily. Thanks! I'll commit shortly...
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209305#comment-13209305 ]
Iulius Curt commented on LUCENE-3109:
-------------------------------------
Is this still valid? (It looks like a good place for me to enter the community)
Should also the *FieldsReader/Writer classes that derive FieldsProducer/Consumer become *InvertedFieldsReader/Writer?
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249520#comment-13249520 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
bq. We need to change CHANGES.txt and MIGRATE.txt to the new API, it's now heavily outdated.
Thanks Uwe, you're right, my bad.
bq. Should we change AtomicReader to have invertedField() instead fields()?
+1
bq. Also the name FieldsEnum is now inconsistent.
I think it should be InvertedFieldsEnum?
Iulius do you want to make these changes? Or I can... let me know.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249551#comment-13249551 ]
Robert Muir commented on LUCENE-3109:
-------------------------------------
Also I think there are other improvements we can do here that would be more natural:
* Fields.getUniqueFieldCount() -> Fields.size()
* Terms.getUniqueTermCount() -> Terms.size()
In general the names of the other statistics could probably use some help.
When i gave a lucene talk on the new stats i had to add "wtf are these things in english"
beside the name of each new stat. I can't suggest good java names at this time,
but these are the english names:
* Terms.getDocCount() -> "number of documents with value"
* Terms.getSumDocFreq() -> "number of postings"
* Terms.getSumTotalTermFreq() -> "number of tokens"
TermsEnum.totalTermFreq is probably ok, but maybe it was named that way
only to be consistent with docFreq? Really something like "number of occurrences"
is what most people would expect here.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249545#comment-13249545 ]
Robert Muir commented on LUCENE-3109:
-------------------------------------
I don't understand the reasoning to add "Inverted" to all these apis.
its damaging when we had a perfectly good single-syllable "Fields" before.
Now we make a harder-to-consume multi-syllable API, for what reason?
What other kind of Field is there?!
But, again I'm not gonna spark a huge argument/discussion about this.
I'm just asking for a revert.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249556#comment-13249556 ]
Robert Muir commented on LUCENE-3109:
-------------------------------------
Also just another idea to throw out there:
* AtomicReader.termDocsEnum -> AtomicReader.termDocs
* AtomicReader.termPositionsEnum -> AtomicReader.termPositions
* TermsEnum.docs -> TermsEnum.termDocs
* TermsEnum.docsAndPositions -> TermsEnum.termPositions
This terminology would be more consistent with all previous
lucene APIs and seems like an easy win?
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Iulius Curt updated LUCENE-3109:
--------------------------------
Attachment: LUCENE-3109.patch
It was cleaner to redo it from scratch. Hope didn't miss anything this time.
It built fine and tests got passed.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-3109.
----------------------------------------
Resolution: Fixed
Assignee: Michael McCandless
Thanks Iulius!
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249524#comment-13249524 ]
Uwe Schindler commented on LUCENE-3109:
---------------------------------------
I can do it, too (not now). It's 5 minutes work with Eclipse...
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248604#comment-13248604 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
Hi Iulius, this patch is great: this rename is badly needed...
I was able to apply the patch (resolving a few conflicts since the code has shifted since it was created), but... some things seem to be missing (eg InvertedFieldsProducer rename). How did you generate the patch?
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249517#comment-13249517 ]
Uwe Schindler commented on LUCENE-3109:
---------------------------------------
We also changed public APIs (Fields -> InvertedFields). We need to change CHANGES.txt and MIGRATE.txt to the new API, it's now heavily outdated.
Should we change AtomicReader to have invertedField() instead fields()? Also the name FieldsEnum is now inconsistent.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Reopened] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Uwe Schindler (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reopened LUCENE-3109:
-----------------------------------
Documentation fixes needed.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Iulius Curt updated LUCENE-3109:
--------------------------------
Attachment: LUCENE-3109.patch
Attached a patch with the refactoring of Fields, FieldsProducer, FieldsConsumer and any other related classes.
It turned out to be pretty ample (also affected Solr)
Please give some feedback if something is wrong.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Iulius Curt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Iulius Curt updated LUCENE-3109:
--------------------------------
Attachment: LUCENE-3109.patch
bq. In general I prefer seeing each import (not the wildcard)... can you redo patch putting them back? Thanks!
Totally agree on that. I should blame IDEA for this one, should I?
Thanks for all the patience.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249549#comment-13249549 ]
Robert Muir commented on LUCENE-3109:
-------------------------------------
Thanks, when looking at naming of apis that users will interact with,
I think we should go with the simplest possible naming thats easiest to consume.
For example things like "Term", "Query", "Document", etc. I think this kind of
naming helps to keep the API consumable: as far as more expert stuff inside codec,
thats sort of a different story (though we shouldnt just name it whatever, i think
we don't have to be nearly as picky about names).
For the core APIs that hook into IndexReader and IndexWriter, and for things in
the o.a.l.document package, and things like that, I think we should be shooting
for these super-simplistic names that have worked for lucene all along.
To me, taking an IndexReader and enumerating Fields->FieldsEnum->Terms->TermsEnum...
is pretty clear and makes sense.
Fields and Terms being plural makes sense to me, but one improvement to think of is
removing the confusing plural ending of these enum classes (FieldEnum, TermEnum).
It seems this only have existed to not conflict with the pre-flex API before
(for backwards compatibility). I think that would be an easy improvement to
those enum classes..., for consistency maybe do the same with DocsEnum, or even
think of a new name for that one entirely, I'm not sure.
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to
InvertedFieldsConsumer
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249398#comment-13249398 ]
Michael McCandless commented on LUCENE-3109:
--------------------------------------------
Hmm, one thing: I noticed the imports got changed into wildcards, eg:
{noformat}
+import org.apache.lucene.index.*;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.document.Document;
import org.apache.lucene.document.TextField;
-import org.apache.lucene.index.RandomIndexWriter;
-import org.apache.lucene.index.TermsEnum;
-import org.apache.lucene.index.IndexReader;
-import org.apache.lucene.index.Term;
-import org.apache.lucene.index.MultiFields;
+import org.apache.lucene.index.MultiInvertedFields;
{noformat}
In general I prefer seeing each import (not the wildcard)... can you redo patch putting them back? Thanks!
(I'm assuming/hoping this is a simple setting in your IDE?).
> Rename FieldsConsumer to InvertedFieldsConsumer
> -----------------------------------------------
>
> Key: LUCENE-3109
> URL: https://issues.apache.org/jira/browse/LUCENE-3109
> Project: Lucene - Java
> Issue Type: Task
> Components: core/codecs
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch, LUCENE-3109.patch
>
>
> The name FieldsConsumer is missleading here it really is an InvertedFieldsConsumer and since we are extending codecs to consume non-inverted Fields we should be clear here. Same applies to Fields.java as well as FieldsProducer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org