You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Takashi Okamoto (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 13:26:10 UTC
[jira] [Created] (CB-210) Fileupload is broken for multibyte
filename
Fileupload is broken for multibyte filename
-------------------------------------------
Key: CB-210
URL: https://issues.apache.org/jira/browse/CB-210
Project: Apache Callback
Issue Type: Bug
Components: Android
Affects Versions: 1.3.0
Reporter: Takashi Okamoto
Assignee: Joe Bowser
File name is broken hen file name include multibyte character.
As far as I check the code,
FileTransfer.java may have problem.
dos.writeBytes("Content-Disposition: form-data; name=\"" + new String(fileKey.getBytes("UTF-8"),"ISO-8859-1") + "\";" + " filename=\"" + new String(fileName.getBytes("UTF-8"),"ISO-8859-1") + "\"" + LINE_END);
Should it be filename.getBytes("utf-8")? fileKey also same problem.
regards,
Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Joe Bowser (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-210.
---------------------------
Resolution: Fixed
Should be fixed in master
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
> Fix For: 1.6.0
>
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Simon MacDonald (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203855#comment-13203855 ]
Simon MacDonald commented on CB-210:
------------------------------------
Yeah, he had a fix. Now that he's signed the CLA I will put it in.
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Simon MacDonald
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Joe Bowser (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-210:
--------------------------
Fix Version/s: 1.6.0
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
> Fix For: 1.6.0
>
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Joe Bowser (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223730#comment-13223730 ]
Joe Bowser commented on CB-210:
-------------------------------
Hello
I'm finally getting around to adding your fix. Can you please send me a test case so I can make sure this works?
Thanks
Joe
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
> Fix For: 1.6.0
>
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Joe Bowser (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203851#comment-13203851 ]
Joe Bowser commented on CB-210:
-------------------------------
Can you clarify what exactly you are referring to? Are you proposing a fix?
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Simon MacDonald (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon MacDonald reassigned CB-210:
----------------------------------
Assignee: Simon MacDonald (was: Joe Bowser)
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Simon MacDonald
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Joe Bowser (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser reassigned CB-210:
-----------------------------
Assignee: Joe Bowser (was: Simon MacDonald)
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
> Fix For: 1.6.0
>
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-210) Fileupload is broken for multibyte
filename
Posted by "Takashi Okamoto (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Takashi Okamoto updated CB-210:
-------------------------------
Description:
File name is broken hen file name include multibyte character.
As far as I check the code,
FileTransfer.java may have problem.
dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
regards,
Takashi Okamoto
was:
File name is broken hen file name include multibyte character.
As far as I check the code,
FileTransfer.java may have problem.
dos.writeBytes("Content-Disposition: form-data; name=\"" + new String(fileKey.getBytes("UTF-8"),"ISO-8859-1") + "\";" + " filename=\"" + new String(fileName.getBytes("UTF-8"),"ISO-8859-1") + "\"" + LINE_END);
Should it be filename.getBytes("utf-8")? fileKey also same problem.
regards,
Takashi Okamoto
> Fileupload is broken for multibyte filename
> -------------------------------------------
>
> Key: CB-210
> URL: https://issues.apache.org/jira/browse/CB-210
> Project: Apache Callback
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Takashi Okamoto
> Assignee: Joe Bowser
>
> File name is broken hen file name include multibyte character.
> As far as I check the code,
> FileTransfer.java may have problem.
> dos.writeBytes("Content-Disposition: form-data; name=\"" + fileKey + "\";" + " filename=\"" + fileName + "\"" + LINE_END);
>
> It must new String(filename.getBytes("UTF-8"), "ISO-8859-1") and it works fine.
> regards,
> Takashi Okamoto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira