You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/03 17:21:17 UTC

[GitHub] [spark] cloud-fan edited a comment on issue #26507: [SPARK-29904][SQL][2.4] Parse timestamps in microsecond precision by JSON/CSV datasources

cloud-fan edited a comment on issue #26507: [SPARK-29904][SQL][2.4] Parse timestamps in microsecond precision by JSON/CSV datasources
URL: https://github.com/apache/spark/pull/26507#issuecomment-581522339
 
 
   The document of [`DataFrameReader.json`](https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.DataFrameReader) says that the `timestampFormat` option supports the pattern string of `java.text.SimpleDateFormat`. That said, microseconds precision should be supported if the pattern string contains `SSS`. So this is a bug fix.
   
   I think we should apply it to all the places that promise to support pattern string of `java.text.SimpleDateFormat`, like `to_timestamp`. We may also need to fix the master branch as well when we add back the legacy formatter.
   
   BTW I don't think this is a serious bug that worth to fail the RC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org