You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/04/17 16:56:29 UTC

[GitHub] madlib pull request #263: Bugfix/mlp minibatch grouping

GitHub user iyerr3 opened a pull request:

    https://github.com/apache/madlib/pull/263

    Bugfix/mlp minibatch grouping

    If mini-batch preprocessor is run with grouping, the standardization in the output table is computed per group. This implies that MLP should also be run with the same grouping, else the dataset used for training would be different from the original data, hence making the training invalid. 
    
    This commit ensures that MLP training will proceed only if the grouping column input is same as the one used during preprocessing. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/mlp_minibatch_grouping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit d62e21eb5229f466c8674d6131490aa80a583523
Author: Rahul Iyer <ri...@...>
Date:   2018-04-17T13:30:32Z

    MLP: Ensure grouping_col is same as preprocessed

commit 3d179accd212dd8693db0b874700edc777f1e117
Author: Rahul Iyer <ri...@...>
Date:   2018-04-17T16:48:39Z

    MLP: Grouping input should always be same as preprocessor

----


---

[GitHub] madlib pull request #263: Bugfix/mlp minibatch grouping

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/263


---

[GitHub] madlib issue #263: Bugfix/mlp minibatch grouping

Posted by fmcquillan99 <gi...@git.apache.org>.

Github user fmcquillan99 commented on the issue:

    https://github.com/apache/madlib/pull/263
  
    I tested this quite a bit and it seems to work nicely for me.
    
    LGTM


---

[GitHub] madlib issue #263: Bugfix/mlp minibatch grouping

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/263
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/453/



---