You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/07/02 23:18:21 UTC
[jira] [Created] (MATH-609) [patch] push down code to inner blocks
where they are needed
[patch] push down code to inner blocks where they are needed
------------------------------------------------------------
Key: MATH-609
URL: https://issues.apache.org/jira/browse/MATH-609
Project: Commons Math
Issue Type: Improvement
Affects Versions: 3.0
Reporter: Dave Brosius
Priority: Trivial
Fix For: 3.0
Attachments: bas.diff
code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-609) [patch] push down code to inner
blocks where they are needed
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062762#comment-13062762 ]
Luc Maisonobe commented on MATH-609:
------------------------------------
Looks fine to me too.
> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
> Key: MATH-609
> URL: https://issues.apache.org/jira/browse/MATH-609
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-609) [patch] push down code to inner blocks
where they are needed
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated MATH-609:
------------------------------
Attachment: bas.diff
> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
> Key: MATH-609
> URL: https://issues.apache.org/jira/browse/MATH-609
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-609) [patch] push down code to inner blocks
where they are needed
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz resolved MATH-609.
------------------------------
Resolution: Fixed
Patch applied in r1145004 (r1144996 for OutlineExtractor).
Thanks!
> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
> Key: MATH-609
> URL: https://issues.apache.org/jira/browse/MATH-609
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-609) [patch] push down code to inner
blocks where they are needed
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059131#comment-13059131 ]
Phil Steitz commented on MATH-609:
----------------------------------
Other than extra parens in the last clause of the return in the LaguerreSolver patch, these all look good to me. Anyone have any objections?
Thanks for the patch!
> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
> Key: MATH-609
> URL: https://issues.apache.org/jira/browse/MATH-609
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-609) [patch] push down code to inner blocks
where they are needed
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated MATH-609:
-----------------------------
Affects Version/s: (was: 3.0)
2.0
2.1
2.2
> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
> Key: MATH-609
> URL: https://issues.apache.org/jira/browse/MATH-609
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down to where those calculations are needed, to avoid executing code that is unnecessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira