[jira] [Commented] (AIRFLOW-4430) Improper link on "Zoom into SubDAG" button

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830445#comment-16830445 ] 

ASF GitHub Bot commented on AIRFLOW-4430:
-----------------------------------------

marcusianlevine commented on pull request #5212: [AIRFLOW-4430] Fix "Zoom into Sub DAG" link
URL: https://github.com/apache/airflow/pull/5212
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-4430
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Fixes the "Zoom into Sub DAG" button to link to the proper URL, and fixes an associated error when looking up the DAG object in the `tree` view for a SubDAG
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Added a unit test for the `tree` view for a subDAG
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improper link on "Zoom into SubDAG" button
> ------------------------------------------
>
>                 Key: AIRFLOW-4430
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4430
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.3
>            Reporter: Marcus Levine
>            Assignee: Marcus Levine
>            Priority: Major
>             Fix For: 1.10.4
>
>
> The "Zoom into SubDAG" link in the task detail modal for subDAGs does not link to the proper location, instead it points to the default DAG view for the current, top-level DAG (not the subDAG)
>  
> In the "example_subdag_operator" DAG for instance, the subDAG link provided on the button  for "section-1" is "/tree?dag_id=example_subdag_operator&execution_date=..." instead of "/tree?dag_id=example_subdag_operator.section-1&execution_date=..."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)