You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by st...@apache.org on 2002/08/14 08:00:19 UTC
cvs commit: xml-axis/java/src/org/apache/axis AxisEngine.java
stevel 2002/08/13 23:00:18
Modified: java/src/org/apache/axis AxisEngine.java
Log:
this doesnt guarantee thread safety on axis engine cleanup handlers, but it reduces the window; it is only if cleanup is called more than once simultaneousy that trouble can happen, rather than sequentially.
yes I do have an MP cpu on my desk, no I havent got a good test for this cleanup yet.
Revision Changes Path
1.93 +6 -0 xml-axis/java/src/org/apache/axis/AxisEngine.java
Index: AxisEngine.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/AxisEngine.java,v
retrieving revision 1.92
retrieving revision 1.93
diff -u -r1.92 -r1.93
--- AxisEngine.java 4 Aug 2002 03:27:24 -0000 1.92
+++ AxisEngine.java 14 Aug 2002 06:00:18 -0000 1.93
@@ -201,6 +201,11 @@
}
+ /**
+ * cleanup routine removes application scoped objects
+ * There is a small risk of this being called more than once
+ * so the cleanup should be designed to resist that event
+ */
public void cleanup() {
super.cleanup();
@@ -214,6 +219,7 @@
if (obj != null && obj instanceof ServiceLifecycle) {
((ServiceLifecycle)obj).destroy();
}
+ session.remove(key);
}
}
}