You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/03 03:45:08 UTC
[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new pull request
#110: fix apache apisix icon not show issue
lilien1010 opened a new pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110
get ico link from index.html ，so that the ico link keep Consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue
#110: fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#issuecomment-570593154
After several attempts, I find that the icon only disappears when we use `history` mode, the Dashboard is using `hash` mode by default.
If using `history` mode suits your needs, please update the codes in `SidebarLogo.vue` file: Just use `favicon.ico` instead of `/favicon.ico`, then run `yarn build:prod`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #110: fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r362812355
##########
File path: src/layout/components/Sidebar/SidebarLogo.vue
##########
@@ -69,6 +69,29 @@ export default class extends Vue {
@Prop({ required: true }) private collapse!: boolean
private title = 'APISIX'
+
+ get getIco() {
Review comment:
We could use an elegant way to fix this issue... Let me check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan closed pull request #110:
fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #110: fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r363155166
##########
File path: src/layout/components/Sidebar/SidebarLogo.vue
##########
@@ -69,6 +69,29 @@ export default class extends Vue {
@Prop({ required: true }) private collapse!: boolean
private title = 'APISIX'
+
+ get getIco() {
Review comment:
I'd love to know if the latest version of dashboard is working on your side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #110: fix
apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#issuecomment-570593154
After several attempts, I find that the icon only disappears when we use `history` mode, the Dashboard is using `hash` mode by default.
If using `history` mode suits your needs, please update the codes in `SidebarLogo.vue` file: Just use `favicon.ico` instead of `/favicon.ico`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in
pull request #110: fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r363132755
##########
File path: src/layout/components/Sidebar/SidebarLogo.vue
##########
@@ -69,6 +69,29 @@ export default class extends Vue {
@Prop({ required: true }) private collapse!: boolean
private title = 'APISIX'
+
+ get getIco() {
Review comment:
sure thisPR is too complicated, but I think use the same link from link.rel will keep the Icon link consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #110: fix apache apisix icon not show issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r363155166
##########
File path: src/layout/components/Sidebar/SidebarLogo.vue
##########
@@ -69,6 +69,29 @@ export default class extends Vue {
@Prop({ required: true }) private collapse!: boolean
private title = 'APISIX'
+
+ get getIco() {
Review comment:
haha I'd love to know if the latest version of dashboard is working on your side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services