You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/04/26 14:01:08 UTC

[GitHub] garrensmith commented on a change in pull request #906: Toolbar redesign for all docs

garrensmith commented on a change in pull request #906: Toolbar redesign for all docs
URL: https://github.com/apache/couchdb-fauxton/pull/906#discussion_r113455793
 
 

 ##########
 File path: app/addons/documents/index-results/index-results.components.js
 ##########
 @@ -172,16 +160,19 @@ var TableRow = React.createClass({
     });
   },
 
+  onDoubleClick: function (e) {
+    this.props.onDoubleClick(this.props.el._id, this.props.el, e);
+  },
+
   render: function () {
     var i = this.props.index;
     var docContent = this.props.el.content;
     var el = this.props.el;
 
     return (
-      <tr key={"tableview-content-row-" + i}>
+      <tr key={"tableview-content-row-" + i} onDoubleClick={this.onDoubleClick}>
 
 Review comment:
   I would prefer onClick here. DoubleClick doesn't feel intuitive
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services