You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/24 07:49:12 UTC
[GitHub] [calcite] jinxing64 opened a new pull request #1329: [CALCITE-3209]
Store inputs of MutableMultiRel by ArrayList rather than ImmutableList
jinxing64 opened a new pull request #1329: [CALCITE-3209] Store inputs of MutableMultiRel by ArrayList rather than ImmutableList
URL: https://github.com/apache/calcite/pull/1329
When digging code of materialization matching. I found the current implementation of `MutableMultiRel::inputs` is by an `ImmutableList`, thus impossible to be changed by
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableMultiRel.java#L42
```
@Override public void setInput(int ordinalInParent, MutableRel input)
```
Seems a mistake.
This PR propose to store inputs of MutableMultiRel by ArrayList rather than ImmutableList
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services