[jira] [Resolved] (NUTCH-3160) Leftover System.exit(..) in CommonCrawlDataDumper

["Lewis John McGibbney (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NUTCH-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lewis John McGibbney resolved NUTCH-3160.
-----------------------------------------
    Resolution: Fixed

Thank you [~lfoppiano] 

> Leftover System.exit(..) in CommonCrawlDataDumper
> -------------------------------------------------
>
>                 Key: NUTCH-3160
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3160
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 1.22
>            Reporter: Luca Foppiano
>            Assignee: Luca Foppiano
>            Priority: Minor
>             Fix For: 1.23
>
>
> Hi all, 
>   this is my first issue here. 
> Just a small leftover from NUTCH-2852
> There is a `System.exit()` instead of a `return` in `CommonCrawlDataDumper.dump()`, this usually kills the test that is calling the method.
> ```
> LinkDbReader linkDbReader = null;
>     if (linkdb != null) {
>       linkDbReader = new LinkDbReader(nutchConfig, new Path(linkdb.toString()));
>     }
>     if (parts == null || parts.size() == 0) {
>       LOG.error( "No segment directories found in {} ",
>           segmentRootDir.getAbsolutePath());
>       System.exit(1);
>     }
>     LOG.info("Found {} segment parts", parts.size());
>     if (gzip && !warc) {
>       fileList = new ArrayList<>();
>       constructNewStream(outputDir);
>     }
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)