[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3726: Add redirect to link profiles page on TP parameter creation

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3726: Add redirect to link profiles page on TP parameter creation
URL: https://github.com/apache/trafficcontrol/pull/3726#discussion_r304151358
 
 

 ##########
 File path: traffic_portal/app/src/common/api/ParameterService.js
 ##########
 @@ -30,9 +30,9 @@ var ParameterService = function(Restangular, $http, $q, locationUtils, messageMo
     this.createParameter = function(parameter) {
         return Restangular.service('parameters').post(parameter)
             .then(
-            function() {
+            function(response) {
                 messageModel.setMessages([ { level: 'success', text: 'Parameter created' } ], true);
-                locationUtils.navigateToPath('/parameters');
 
 Review comment:
   Yeah, @mitchell852 is right. The idea is that if you just created a parameter, you most likely want to then assign that parameter to a profile.
   So it seems like there would be two steps:
   
   1. After creating a parameter, instead of navigating back to the "parameters table" view, navigate to the "profiles linked to this parameter" view.
   2. Automatically open the "assign parameter to profiles" modal.
   When you're done assigning the parameter to profiles, you should end up on the "profiles linked to this parameter" view.
   
   Orphaned parameters don't make much sense, so the easier we can make it to assign parameters to profiles right after creating them, the better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services