You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/15 06:08:02 UTC
[GitHub] [incubator-dolphinscheduler-website] break60 opened a new pull request #267: Migrate the developer module to the community
break60 opened a new pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] break60 commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
break60 commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558844061
##########
File path: community/en-us/development/DS-License.md
##########
@@ -0,0 +1,42 @@
+## DolphinScheduler-Contributor-License Policy
Review comment:
> A total of 14 documents were migrated from `docs/development` to `community/development`, but the original documents were not removed
What you said, I have fixed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] lgcareer commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
lgcareer commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558834035
##########
File path: site_config/site.js
##########
@@ -51,19 +51,14 @@ export default {
key: 'docs7',
text: '1.1.0(Not Apache Release)',
link: 'https://analysys.github.io/easyscheduler_docs_cn/',
- }
- ]
+ },
+ ],
},
{
key: 'download',
text: 'DOWNLOAD',
link: '/en-us/docs/release/download.html',
},
- {
Review comment:
Moving how to contribute from the devleopment module to the community module has discussed in the dev email list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] dailidong commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
dailidong commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558802739
##########
File path: site_config/site.js
##########
@@ -51,19 +51,14 @@ export default {
key: 'docs7',
text: '1.1.0(Not Apache Release)',
link: 'https://analysys.github.io/easyscheduler_docs_cn/',
- }
- ]
+ },
+ ],
},
{
key: 'download',
text: 'DOWNLOAD',
link: '/en-us/docs/release/download.html',
},
- {
Review comment:
> One question is whether it needs to be removed? (I don't know the discussion context, so this is just a question)
I also confused about moving developer module， is it needed？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558839111
##########
File path: site_config/site.js
##########
@@ -51,19 +51,14 @@ export default {
key: 'docs7',
text: '1.1.0(Not Apache Release)',
link: 'https://analysys.github.io/easyscheduler_docs_cn/',
- }
- ]
+ },
+ ],
},
{
key: 'download',
text: 'DOWNLOAD',
link: '/en-us/docs/release/download.html',
},
- {
Review comment:
The blog module also has removed. What about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558791866
##########
File path: community/en-us/development/DS-License.md
##########
@@ -0,0 +1,42 @@
+## DolphinScheduler-Contributor-License Policy
Review comment:
A total of 14 documents were migrated from `docs/development` to `community/development`, but the original documents were not removed
##########
File path: site_config/site.js
##########
@@ -51,19 +51,14 @@ export default {
key: 'docs7',
text: '1.1.0(Not Apache Release)',
link: 'https://analysys.github.io/easyscheduler_docs_cn/',
- }
- ]
+ },
+ ],
},
{
key: 'download',
text: 'DOWNLOAD',
link: '/en-us/docs/release/download.html',
},
- {
Review comment:
One question is whether it needs to be removed? (I don't know the discussion context, so this is just a question)
##########
File path: site_config/community.jsx
##########
@@ -40,6 +40,64 @@ export default {
}
],
},
+ {
Review comment:
There are 14 documents migrated from `docs` to `community`, but only 12 documents were referenced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] break60 commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
break60 commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r559275979
##########
File path: community/zh-cn/development/developers.md
##########
@@ -0,0 +1 @@
+## 未完成
Review comment:
> I think it's not necceary to move this file to community.
The developer currently has no content and has been deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] lgcareer commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
lgcareer commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558860143
##########
File path: community/zh-cn/development/developers.md
##########
@@ -0,0 +1 @@
+## 未完成
Review comment:
I think it's not necceary to move this file to community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] lgcareer merged pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
lgcareer merged pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] break60 commented on a change in pull request #267: Migrate the developer module contribution guide and committer guide to the community, remove the blog module
Posted by GitBox <gi...@apache.org>.
break60 commented on a change in pull request #267:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/267#discussion_r558842963
##########
File path: site_config/site.js
##########
@@ -51,19 +51,14 @@ export default {
key: 'docs7',
text: '1.1.0(Not Apache Release)',
link: 'https://analysys.github.io/easyscheduler_docs_cn/',
- }
- ]
+ },
+ ],
},
{
key: 'download',
text: 'DOWNLOAD',
link: '/en-us/docs/release/download.html',
},
- {
Review comment:
> The blog module also has removed. What about this?
The blog module is deleted because the articles in the blog are quoted in the community dynamics. The developer module has not been deleted at present, the content only retains the developer guide, and the other content has been migrated to the community. In addition, I personally think that the content of our official website is too repetitive. It is necessary to have a discussion together to make the official website refresher. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org