You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/27 08:06:21 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #25332: Don't crash if operator_extra_links is a property
uranusjr opened a new pull request, #25332:
URL: https://github.com/apache/airflow/pull/25332
See issues like #25243, #24676, and #25215.
This makes operators that implement this as an instance property compatible for task-mapping. We still can't show those extra links (since they are only available against a concrete task), but at least they are runnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1197354974
+1 on a warning or some active notification (maybe even a grayed out link button and a tooltip in the Task Instance modal) so functionality isn't "missing" silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1197925122
BTW, does any of Extra Links work on mapped tasks? Or it just only on my side it won't work at all on mapped task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1199145588
> So essentially, we invent a “fake” extra link class, and use that if the mapped operator fails to access the real extra link attribute, and return some warning information from the webserver when the special extra link class is accessed?
If we can't do "real" extra link easily, that's kinda the best way to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1197980647
@uranusjr #25360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1198141065
> What do y’all think should be a good way to communicate this? This needs to be done during the DAG parcing phase so a log might not be as noticable, but showing a DagWarning feels a bit excessive to me.
UI information (exactly as @josh-fell mentioned) where we see that links are there but not working (grayed out) with comment. This could be a separate PR @bbovenzi @pierrejeambrun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25332: Don't crash if operator_extra_links is a property
URL: https://github.com/apache/airflow/pull/25332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1199044267
So essentially, we invent a “fake” extra link class, and use that if the mapped operator fails to access the real extra link attribute, and return some warning information from the webserver when the special extra link class is accessed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1250160288
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1197748936
What do y’all think should be a good way to communicate this? This needs to be done during the DAG parcing phase so a log might not be as noticable, but showing a DagWarning feels a bit excessive to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1198307161
> UI information (exactly as @josh-fell mentioned) where we see that links are there but not working (grayed out) with comment. This could be a separate PR @bbovenzi @pierrejeambrun ?
I like Josh's suggestion. We can do that if we add an extra error case in the [webserver](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25332: Don't crash if operator_extra_links is a property
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25332:
URL: https://github.com/apache/airflow/pull/25332#issuecomment-1197926134
What does not work for you? Open a new issue for that, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org