You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 19:26:08 UTC

[GitHub] [airflow] vandonr-amz opened a new pull request, #27579: sagemaker operators: mutualize init of aws_conn_id

vandonr-amz opened a new pull request, #27579:
URL: https://github.com/apache/airflow/pull/27579

   this is done in all initializations, and we even rely on it being there in the `hook` property [on l.112](https://github.com/aws-mwaa/upstream-to-airflow/blob/b3dbcf91196de3f07434f16d2fae00d1ceaa0a5a/airflow/providers/amazon/aws/operators/sagemaker.py#L112)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #27579: sagemaker operators: mutualize init of aws_conn_id

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27579:
URL: https://github.com/apache/airflow/pull/27579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Taragolis commented on a diff in pull request #27579: sagemaker operators: mutualize init of aws_conn_id

Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #27579:
URL: https://github.com/apache/airflow/pull/27579#discussion_r1018395997


##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -51,9 +51,10 @@ class SageMakerBaseOperator(BaseOperator):
     ui_color: str = "#ededed"
     integer_fields: list[list[Any]] = []
 
-    def __init__(self, *, config: dict, **kwargs):
+    def __init__(self, *, config: dict, aws_conn_id: str, **kwargs):

Review Comment:
   ```suggestion
       def __init__(self, *, config: dict, aws_conn_id: str = DEFAULT_CONN_ID, **kwargs):
   ```
   
   Some suggestion which also might fix failed tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org