You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bifromq.apache.org by "pallavithegod (via GitHub)" <gi...@apache.org> on 2026/10/14 16:09:07 UTC

[PR] Fix compactor thread and metrics leak in RocksDBKVSpace [bifromq]

pallavithegod opened a new pull request, #320:
URL: https://github.com/apache/bifromq/pull/320

   ## Summary
   Each KV space created its own `compactionExecutor` but `doClose`/`doDestroy` never shut it down. Non-daemon threads accumulated on split/merge and blocked JVM exit.
   
   ## Fix
   - `shutdownNow` the executor in `doClose` and `doDestroy`.
   - Remove the nine `kvspace.executor` meters registered by `ExecutorServiceMetrics.monitor`, scoped by space tags.
   
   Fixes #290
   
   ## Verification
   - `base-kv-local-engine-rocksdb` compiles: BUILD SUCCESS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix compactor thread and metrics leak in RocksDBKVSpace [bifromq]

Posted by "popduke (via GitHub)" <gi...@apache.org>.

popduke closed pull request #320: Fix compactor thread and metrics leak in RocksDBKVSpace
URL: https://github.com/apache/bifromq/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix compactor thread and metrics leak in RocksDBKVSpace [bifromq]

Posted by "popduke (via GitHub)" <gi...@apache.org>.

popduke commented on PR #320:
URL: https://github.com/apache/bifromq/pull/320#issuecomment-6492450763

   Closed as fixed in #321 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org