[GitHub] [skywalking-python] Superskyyy commented on a change in pull request #174: Introduce another set of flake8 extensions

[GitBox <gi...@apache.org>]

Superskyyy commented on a change in pull request #174:
URL: https://github.com/apache/skywalking-python/pull/174#discussion_r735070530



##########
File path: setup.cfg
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+[flake8]
+
+# run with `--disable-noqa` to reevaluate skipped inspections
+# Do not use ignore option, it will override some plugin's default ignore
+extend-ignore =
+    E303, # Too many blank lines | Conflict with Pycharm
+    E126, # Continuation line over-indented for hanging indent | Conflict with Pycharm
+    E501, # Line too long | Customized by max-line-length
+    W503, # Line break occurred before a binary operator | Conflict with W504
+    # temporarily banned rules for various reasons, likely to re-enable in the future
+    E800, # Found commented out code | Temporarily disabled for legacy code
+    D, # docstring | To be enhanced, large number
+    DAR, # docstring structure | To be fixed
+
+
+max-line-length = 120
+max-complexity = 20
+exclude = venv*,*egg_info,skywalking/protocol

Review comment:
       `skywalking/protocol` is the generated protobuf Python code, it should be excluded or lint complaints. The `skywalking/agent/protocol` is what contains the project code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org