You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by rovarga <gi...@git.apache.org> on 2018/10/01 17:55:23 UTC

[GitHub] mina-sshd pull request #67: [SSHD-846] Allow KeyPairGenerators to be garbage...

GitHub user rovarga opened a pull request:

    https://github.com/apache/mina-sshd/pull/67

    [SSHD-846] Allow KeyPairGenerators to be garbage-collected

    Since we do not use the KeyPairGenerator once we have generated the keypair, make sure we remove our reference so it can be garbage-collected. With Bouncy Castle that translates to around ~34KiB memory savings per session.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rovarga/mina-sshd dh-keygen

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
    
----
commit 90e4ebd11295a2164f60bc7a4c4b2fce68e35292
Author: Robert Varga <ro...@...>
Date:   2018-10-01T17:44:09Z

    [SSHD-846] Allow KeyPairGenerators to be garbage-collected

----


---

[GitHub] mina-sshd pull request #67: [SSHD-846] Allow KeyPairGenerators to be garbage...

Posted by rovarga <gi...@git.apache.org>.

Github user rovarga closed the pull request at:

    https://github.com/apache/mina-sshd/pull/67


---