You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/08/25 01:43:10 UTC
[PR] KAFKA-17407: Fix flaky ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics [kafka]
m1a2st opened a new pull request, #16994:
URL: https://github.com/apache/kafka/pull/16994
Jira: https://issues.apache.org/jira/browse/KAFKA-17407
In my opinion, the old test run twice in https://github.com/apache/kafka/blob/4a485ddb71c844acc8bf241feda1fcbffc5ce9be/core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala#L460 and make the epoch plus twice is wired, I think the root cause is
https://github.com/apache/kafka/blob/4a485ddb71c844acc8bf241feda1fcbffc5ce9be/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L2197
https://github.com/apache/kafka/blob/4a485ddb71c844acc8bf241feda1fcbffc5ce9be/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L2178
It seen need some time to update the `updatedMember` variable, thus I make the thread to sleep 1s.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17407: Fix flaky ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16994:
URL: https://github.com/apache/kafka/pull/16994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17407: Fix flaky ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16994:
URL: https://github.com/apache/kafka/pull/16994#issuecomment-2408279705
@chia7712, @AndrewJSchofield Thanks for your review, it seens pass the ci, and flaky anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17407: Fix flaky ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #16994:
URL: https://github.com/apache/kafka/pull/16994#issuecomment-2407204039
@m1a2st Thanks for the PR. I still see failure with this test after the patch.
```
Gradle Test Run :core:test > Gradle Test Executor 47 > ShareGroupHeartbeatRequestTest > testPartitionAssignmentWithChangingTopics() > testPartitionAssignmentWithChangingTopics [1] Type=Raft-Isolated, MetadataVersion=4.0-IV3,Security=PLAINTEXT FAILED
org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
at app//kafka.server.ShareGroupHeartbeatRequestTest.testPartitionAssignmentWithChangingTopics(ShareGroupHeartbeatRequestTest.scala:471)
```
It took 17 iterations to fail but still flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org