You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "iprithv (via GitHub)" <gi...@apache.org> on 2026/05/27 18:23:00 UTC

[PR] Fix IBSimilarity with DistributionSPL producing negative scores [lucene]

iprithv opened a new pull request, #16139:
URL: https://github.com/apache/lucene/pull/16139

   IBSimilarity with DistributionSPL could produce negative scores due to floating-point rounding errors when lambda is extremely close to 1. This breaks the contract that Lucene scores must be non-negative.
   
   #16137, so clamped the computed score to be non-negative.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix IBSimilarity with DistributionSPL producing negative scores [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16139:
URL: https://github.com/apache/lucene/pull/16139#issuecomment-4700297611

   This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix IBSimilarity with DistributionSPL producing negative scores [lucene]

Posted by "msfroh (via GitHub)" <gi...@apache.org>.
msfroh merged PR #16139:
URL: https://github.com/apache/lucene/pull/16139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix IBSimilarity with DistributionSPL producing negative scores [lucene]

Posted by "iprithv (via GitHub)" <gi...@apache.org>.
iprithv commented on PR #16139:
URL: https://github.com/apache/lucene/pull/16139#issuecomment-4727757101

   @romseygeek I think this should be ideal fix for now. also we do the same in Axiomatic..And i did some digging and tried other ways but couldn't find any better fix..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix IBSimilarity with DistributionSPL producing negative scores [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16139:
URL: https://github.com/apache/lucene/pull/16139#issuecomment-4940814830

   This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org