You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "anton-vinogradov (via GitHub)" <gi...@apache.org> on 2023/06/28 14:20:04 UTC
[GitHub] [ignite] anton-vinogradov opened a new pull request, #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
anton-vinogradov opened a new pull request, #10814:
URL: https://github.com/apache/ignite/pull/10814
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246722538
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -94,7 +94,7 @@ public class GridDhtTxLocal extends GridDhtTxLocalAdapter implements GridCacheMa
private volatile GridDhtTxPrepareFuture prepFut;
/** Transaction label. */
- private @Nullable String lb;
+ private final @Nullable String lb;
Review Comment:
This patch is pretty simple while another files require much more changes, eg. IGNITE-19873
Doing the same for all files to keep prosess clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10814:
URL: https://github.com/apache/ignite/pull/10814#issuecomment-1611519607
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10814)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10814&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10814&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10814&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10814&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10814&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10814&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10814&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246593358
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -94,7 +94,7 @@ public class GridDhtTxLocal extends GridDhtTxLocalAdapter implements GridCacheMa
private volatile GridDhtTxPrepareFuture prepFut;
/** Transaction label. */
- private @Nullable String lb;
+ private final @Nullable String lb;
Review Comment:
Looks like `lb`, `prepFut` and `PREP_FUT_UPD` can be moved to upper class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246578667
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
What about adding generics for variables of `GridCacheSharedContext`, `GridCacheContext`, `GridDhtTxFinishFuture`, `IgniteInternalFuture` classes to remove warnings? At least we can add `<?>` and `<?, ?>` without any problems here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246612483
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -94,7 +94,7 @@ public class GridDhtTxLocal extends GridDhtTxLocalAdapter implements GridCacheMa
private volatile GridDhtTxPrepareFuture prepFut;
/** Transaction label. */
- private @Nullable String lb;
+ private final @Nullable String lb;
Review Comment:
Sure, but current goal is just to apply IDEA's tips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246690399
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
> current goal is just to apply IDEA's tips
One of IDEA's tips is to add generics. There is nothing to refactor, just add <?> to variables declarations in places, where IDEA complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246690399
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
> current goal is just to apply IDEA's tips
One of IDEA's tips is to add generics. There is nothing to refactor, just add <?> to variables declarations in places, where IDEA complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246703196
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -94,7 +94,7 @@ public class GridDhtTxLocal extends GridDhtTxLocalAdapter implements GridCacheMa
private volatile GridDhtTxPrepareFuture prepFut;
/** Transaction label. */
- private @Nullable String lb;
+ private final @Nullable String lb;
Review Comment:
The goal looks strange. It's a small refactoring anyway, why both of these refactorings can't be done together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov merged PR #10814:
URL: https://github.com/apache/ignite/pull/10814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246719559
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
Correct, but the goal is to move step by step.
Initial goal is to finalize fields and remove everything unused.
This should help to keep patches as simple as posslible.
The main review question - is the patch ok, not - is it complete. Can we agree on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246719559
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
Correct, but the goal is to move step by step.
Initial goal is to finalize fields and remove everything unused.
This should help to keep patches as simple as posslible.
The main review question - is the patch ok, not - is it complete. Can we aggree on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10814:
URL: https://github.com/apache/ignite/pull/10814#discussion_r1246611542
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java:
##########
@@ -244,13 +244,6 @@ public void nearFutureId(IgniteUuid nearFutId) {
return cacheCtx.isDht() && isNearEnabled(cacheCtx) && !cctx.localNodeId().equals(nearNodeId());
Review Comment:
It's just an initial dummy cleanup.
Going to refactor later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org