You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2017/03/30 19:40:19 UTC
[5/5] kudu git commit: [scanners] info message on scanner expiration
is back
[scanners] info message on scanner expiration is back
Despite of the TODO, logging about expired scanner seems to be useful
for troubleshooting.
This is follow-up for 5df142fa35bf04231ee92b622482a1be0b18b294.
Change-Id: If94558cfab9ae31c68f58c886becc968138c18e2
Reviewed-on: http://gerrit.cloudera.org:8080/6435
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/08b8ec9e
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/08b8ec9e
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/08b8ec9e
Branch: refs/heads/master
Commit: 08b8ec9e1a7949bf569353eafdf029b6d0276473
Parents: f8e88fa
Author: Alexey Serbin <as...@cloudera.com>
Authored: Sun Mar 19 17:19:25 2017 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Thu Mar 30 01:21:59 2017 +0000
----------------------------------------------------------------------
src/kudu/tserver/scanners.cc | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/08b8ec9e/src/kudu/tserver/scanners.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/scanners.cc b/src/kudu/tserver/scanners.cc
index 7d9a821..43d8144 100644
--- a/src/kudu/tserver/scanners.cc
+++ b/src/kudu/tserver/scanners.cc
@@ -170,12 +170,13 @@ void ScannerManager::RemoveExpiredScanners() {
}
// The scanner has expired because of inactivity.
- VLOG(1) << Substitute("Expiring scanner id: $0, of tablet $1, "
- "after $2 ms of inactivity, which is > TTL ($3 ms).",
- it->first,
- scanner->tablet_id(),
- idle_time.ToMilliseconds(),
- scanner_ttl.ToMilliseconds());
+ LOG(INFO) << Substitute(
+ "Expiring scanner id: $0, of tablet $1, "
+ "after $2 ms of inactivity, which is > TTL ($3 ms).",
+ it->first,
+ scanner->tablet_id(),
+ idle_time.ToMilliseconds(),
+ scanner_ttl.ToMilliseconds());
it = stripe->scanners_by_id_.erase(it);
if (metrics_) {
metrics_->scanners_expired->Increment();