You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/11 08:41:19 UTC

[GitHub] [systemds] tobiasrieger opened a new pull request #1014: [MINOR] Marked nn examples deprecated

tobiasrieger opened a new pull request #1014:
URL: https://github.com/apache/systemds/pull/1014


   Found deprecated nn examples. Tested with most recent python library built from source.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1014: [MINOR] Marked nn examples deprecated

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1014:
URL: https://github.com/apache/systemds/pull/1014#issuecomment-673362469


   Thanks @tobiasrieger,
   
   I went through the commit and it seems solid. GJ :100: 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] j143 commented on pull request #1014: [MINOR] Marked nn examples deprecated

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1014:
URL: https://github.com/apache/systemds/pull/1014#issuecomment-672778140


   Hi @tobiasrieger - Thank you.
   
   I reviewed this PR cursorily, few things before a deep pass at this PR.
   
   1.  It's okay to **refactor** or **improve** the existing code instead to create a new code. 
   2. Let's look at how we can incorporate these changes into the existing .dml scripts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard closed pull request #1014: [MINOR] Marked nn examples deprecated

Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1014:
URL: https://github.com/apache/systemds/pull/1014


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] j143 commented on pull request #1014: [MINOR] Marked nn examples deprecated

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1014:
URL: https://github.com/apache/systemds/pull/1014#issuecomment-672840899


   We started discussion about this in mailing list.
   
   **How to subscribe?**
   
   mailto:dev-subscribe@systemds.apache.org
   
   You will greeted by a friendly bot with simple instructions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org