You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/30 06:07:44 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4148: Support
customized instance name by a new UUID naming policy.
wu-sheng opened a new pull request #4148: Support customized instance name by a new UUID naming policy.
URL: https://github.com/apache/skywalking/pull/4148
The new naming policy of register UUID.
Instance uuid is the identity of an instance, SkyWalking treat same instance uuid as one instance.if empty, SkyWalking agent will generate an 32-bit uuid. Using `NAME:` as UUID prefix could set the customized instance name. Such as, set it as `NAME:SVR-INSTANCE-A`, `SVR-INSTANCE-A` is the instance name. Otherwise, use `ServiceName`-pid:`id`@`hostname` as the instance name.
To be noticed, this policy will be used in client-js subproject. As the browser side, it should not register based on client IP, that will be uncountable. At the same time, agent use could use this if they don't like our existing name policy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4148: Support
customized instance name by a new UUID naming policy.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4148: Support customized instance name by a new UUID naming policy.
URL: https://github.com/apache/skywalking/pull/4148#issuecomment-569598264
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=h1) Report
> Merging [#4148](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/6af14a36bcaa94741cd1a2709ba3193d5f764b9c?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4148 +/- ##
==========================================
- Coverage 27.18% 27.18% -0.01%
==========================================
Files 1145 1145
Lines 25100 25105 +5
Branches 3629 3631 +2
==========================================
Hits 6824 6824
- Misses 17670 17675 +5
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ovider/handler/v6/grpc/RegisterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4148/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvaGFuZGxlci92Ni9ncnBjL1JlZ2lzdGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=footer). Last update [6af14a3...62a92b7](https://codecov.io/gh/apache/skywalking/pull/4148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4148: Support customized
instance name by a new UUID naming policy.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4148: Support customized instance name by a new UUID naming policy.
URL: https://github.com/apache/skywalking/pull/4148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services