You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/12/14 14:03:48 UTC

[GitHub] [trafficserver] traeak commented on a diff in pull request #9232: Add support for CMCD-Request header nor field to prefetch plugin

traeak commented on code in PR #9232:
URL: https://github.com/apache/trafficserver/pull/9232#discussion_r1048508207


##########
plugins/prefetch/plugin.cc:
##########
@@ -450,7 +499,7 @@ contHandleFetch(const TSCont contp, TSEvent event, void *edata)
     }
     if (!appendCacheKey(txnp, reqBuffer, data->_cachekey)) {
       PrefetchError("failed to get the cache key");
-      TSHttpTxnReenable(txnp, TS_EVENT_HTTP_ERROR);
+      TSHttpTxnReenable(txnp, TS_EVENT_HTTP_CONTINUE);

Review Comment:
   A failed prefetch was causing the original transaction to abort.  I'm sure that's undesireable behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org