You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dave Lester <dl...@apache.org> on 2015/10/26 09:46:28 UTC
Review Request 39645: Updates /site to reflect Niklas' 0.25.0 changes
that weren't reflected in git.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39645/
-----------------------------------------------------------
Review request for mesos, Adam B and Niklas Nielsen.
Repository: mesos
Description
-------
Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.
Diffs
-----
site/source/blog/2015-10-12-mesos-0-25-0-released.md PRE-CREATION
site/source/downloads.html.md 49827fff0dedebc4738afbd02f17d746de72b5d6
site/source/index.html.md b43325ab14c79f6b27db49fd52ea14d8d77c46c6
Diff: https://reviews.apache.org/r/39645/diff/
Testing
-------
The website was built locally using rake, and these changes were reflected properly.
Thanks,
Dave Lester
Re: Review Request 39645: Updates /site to reflect Niklas' 0.25.0
changes that weren't reflected in git.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39645/#review103988
-----------------------------------------------------------
Bad patch!
Reviews applied: [39645]
Failed command: ./support/apply-review.sh -n -r 39645
Error:
2015-10-26 08:56:45 URL:https://reviews.apache.org/r/39645/diff/raw/ [6490/6490] -> "39645.patch" [1]
39645.patch:43: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Successfully applied: Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.
Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.
Review: https://reviews.apache.org/r/39645
site/source/blog/2015-10-12-mesos-0-25-0-released.md:37: new blank line at EOF.
Failed to commit patch
- Mesos ReviewBot
On Oct. 26, 2015, 8:46 a.m., Dave Lester wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39645/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 8:46 a.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.
>
>
> Diffs
> -----
>
> site/source/blog/2015-10-12-mesos-0-25-0-released.md PRE-CREATION
> site/source/downloads.html.md 49827fff0dedebc4738afbd02f17d746de72b5d6
> site/source/index.html.md b43325ab14c79f6b27db49fd52ea14d8d77c46c6
>
> Diff: https://reviews.apache.org/r/39645/diff/
>
>
> Testing
> -------
>
> The website was built locally using rake, and these changes were reflected properly.
>
>
> Thanks,
>
> Dave Lester
>
>
Re: Review Request 39645: Updates /site to reflect Niklas' 0.25.0
changes that weren't reflected in git.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39645/#review104016
-----------------------------------------------------------
Ship it!
Thanks! Make ReviewBot happy, and then I'm happy with this too.
site/source/blog/2015-10-12-mesos-0-25-0-released.md (line 37)
<https://reviews.apache.org/r/39645/#comment162205>
ReviewBot seems to be complaining about this new blank line. I know it's in the original from Nik's blog, but let's remove it before committing to git.
- Adam B
On Oct. 26, 2015, 1:46 a.m., Dave Lester wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39645/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 1:46 a.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.
>
>
> Diffs
> -----
>
> site/source/blog/2015-10-12-mesos-0-25-0-released.md PRE-CREATION
> site/source/downloads.html.md 49827fff0dedebc4738afbd02f17d746de72b5d6
> site/source/index.html.md b43325ab14c79f6b27db49fd52ea14d8d77c46c6
>
> Diff: https://reviews.apache.org/r/39645/diff/
>
>
> Testing
> -------
>
> The website was built locally using rake, and these changes were reflected properly.
>
>
> Thanks,
>
> Dave Lester
>
>