You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/17 00:13:34 UTC

[GitHub] [spark] zero323 commented on a change in pull request #28386: [SPARK-26199][SPARK-31517][R] Fix strategy for handling ... names in mutate

zero323 commented on a change in pull request #28386:
URL: https://github.com/apache/spark/pull/28386#discussion_r524793009



##########
File path: R/pkg/R/DataFrame.R
##########
@@ -3444,7 +3445,8 @@ setMethod("as.data.frame",
 #' @note attach since 1.6.0
 setMethod("attach",

Review comment:
       Could we also have some test for this one? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org