[GitHub] [maven] gnodet commented on a diff in pull request #1203: Fix codestyle in model code snippets

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #1203:
URL: https://github.com/apache/maven/pull/1203#discussion_r1265949889


##########
api/maven-api-model/src/main/mdo/maven.mdo:
##########
@@ -2503,27 +2501,23 @@
     /**
      * Reset the {@code executionMap} field to {@code null}
      */
-    public void flushExecutionMap()
-    {
+    public void flushExecutionMap() {
         this.executionMap = null;
     }
+
     /**
      * @return a Map of executions field with {@code PluginExecution#getId()} as key
      * @see PluginExecution#getId()
      */
-    public java.util.Map<String, PluginExecution> getExecutionsAsMap()
-    {
-        if ( executionMap == null )
-        {
+    public java.util.Map<String, PluginExecution> getExecutionsAsMap() {

Review Comment:
   Using classes without the full package may lead to compilation errors if the generator does not add the related imports.  Removing the package would tie the code block to the way the generator works.  For example, it can be done for the `java.util.Map` but not for the `java.util.Iterator` below because that one is not imported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org