You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/08 05:47:31 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #742: ORC-837: Reuse HiveDecimalWritable in ConvertTreeReaderFactory

dongjoon-hyun commented on a change in pull request #742:
URL: https://github.com/apache/orc/pull/742#discussion_r684719242



##########
File path: java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java
##########
@@ -814,21 +814,23 @@ public void nextVector(ColumnVector previousVector,
   public static class DecimalFromAnyIntegerTreeReader extends ConvertTreeReader {
     private LongColumnVector longColVector;
     private ColumnVector decimalColVector;
+    private final HiveDecimalWritable reuse;

Review comment:
       Shall we rename `reuse` to `value`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org